FileSystem mods: Changes to snapshot file creation to remove dependencies on blobs.

content/common/fileapi/webfilesystem_impl.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CONTENT_COMMON_FILEAPI_WEBFILESYSTEM_IMPL_H_
 #define CONTENT_COMMON_FILEAPI_WEBFILESYSTEM_IMPL_H_
 
 #include "base/basictypes.h"
 #include "base/compiler_specific.h"
 #include "third_party/WebKit/Source/Platform/chromium/public/WebFileSystem.h"
@@ skipping 42 matching lines @@
       WebKit::WebFileSystemCallbacks*) OVERRIDE;
   virtual void directoryExists(
       const WebKit::WebURL& path,
       WebKit::WebFileSystemCallbacks*) OVERRIDE;
   virtual void readDirectory(
       const WebKit::WebURL& path,
       WebKit::WebFileSystemCallbacks*) OVERRIDE;
   virtual WebKit::WebFileWriter* createFileWriter(
       const WebKit::WebURL& path, WebKit::WebFileWriterClient*) OVERRIDE;
   virtual void createSnapshotFileAndReadMetadata(
+      const WebKit::WebURL& path,
+      WebKit::WebFileSystemCallbacks*);

[kinuko, 2013/01/31 06:37:03]

is this going to have OVERRIDE once WK patch lands?

[michaeln, 2013/01/31 21:41:10]

I see all of the other methods in this class do, so this one probably should
too.

In general though, I'm not sure that's the best practice when it comes to coding
to the webkit API since we have this repository split with no ability to commit
changes together. On the flip-side, we've taken to providing default
{NOTREACHED();} impls of what would/should be pure virtual methods defined in
the webkit api. Seems like the decision to declare OVERRIDE vs not on
derivations is similar in nature. I'm for anything that removes 'friction' from
work that spans the two repositories, but also am for having OVERRIDE there to
catch a base class change such that derivatives aren't actually overriding as
intended.

How about I add the OVERRIDE in the cleanup CL (the 4th in the series) after the
dust has settled. That way if anything is reverted on either side prior to that
cleanup... things will still build and run (less friction).

[kinuko, 2013/02/04 06:16:52]

I'm fine with this approach unless no buildbots complain (I'm afraid some clang
bots may), and mildly agree that having OVERRIDE across different modules could
make code management difficult.

+
+  // DEPRECATED variant being replaced by the above.
+  virtual void createSnapshotFileAndReadMetadata(
       const WebKit::WebURL& blobURL,
       const WebKit::WebURL& path,
-      WebKit::WebFileSystemCallbacks*) OVERRIDE;
+      WebKit::WebFileSystemCallbacks*);
 };
 
 }  // namespace content
 
 #endif  // CONTENT_COMMON_FILEAPI_WEBFILESYSTEM_IMPL_H_