pkg/http/lib/src/io_client.dart - Issue 12084052: Always treat headers as individual strings in pkg/http.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/http/lib/src/io_client.dart

Issue 12084052: Always treat headers as individual strings in pkg/http. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Created 7 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: pkg/http/lib/src/io_client.dart

diff --git a/pkg/http/lib/src/io_client.dart b/pkg/http/lib/src/io_client.dart

index 1a432d6368ae71da7890ca82d6f5bd35afab3f87..5d04ec2ff40952808842530a064ca952fdbe076f 100644

--- a/pkg/http/lib/src/io_client.dart

+++ b/pkg/http/lib/src/io_client.dart

@@ -57,7 +57,9 @@ class IOClient extends BaseClient {

connection.onResponse = (response) {

var headers = {};

- response.headers.forEach((key, value) => headers[key] = value);

+ response.headers.forEach((key, values) {

+ headers[key] = Strings.join(values, ',');

Bob Nystrom 2013/01/29 23:51:54 values.join(',') lib_v2 is like living IN THE FUT

+ });

if (completed) return;

« no previous file with comments | « pkg/http/lib/src/base_request.dart ('k') | pkg/http/test/client_test.dart » ('j') | no next file with comments »