Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(225)

Issue 12084042: Adding action box assets. (Closed)

Created:
7 years, 10 months ago by glotov
Modified:
7 years, 10 months ago
CC:
chromium-reviews, oshima+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Adding action box assets. BUG=138170 TEST=units NOTRY=1 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=180149

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+-6 lines, --6 lines) Patch
A ui/resources/default_100_percent/cros/action_box_button_hover.png View 0 chunks +-1 lines, --1 lines 0 comments Download
A ui/resources/default_100_percent/cros/action_box_button_normal.png View 0 chunks +-1 lines, --1 lines 0 comments Download
A ui/resources/default_100_percent/cros/action_box_button_pressed.png View 0 chunks +-1 lines, --1 lines 0 comments Download
A ui/resources/default_200_percent/cros/action_box_button_hover.png View 0 chunks +-1 lines, --1 lines 0 comments Download
A ui/resources/default_200_percent/cros/action_box_button_normal.png View 0 chunks +-1 lines, --1 lines 0 comments Download
A ui/resources/default_200_percent/cros/action_box_button_pressed.png View 0 chunks +-1 lines, --1 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
glotov
Hi! Please take a look.
7 years, 10 months ago (2013-01-29 12:40:45 UTC) #1
oshima
lgtm
7 years, 10 months ago (2013-01-29 20:01:33 UTC) #2
Nikita (slow)
lgtm trybots do not handle new assets well
7 years, 10 months ago (2013-01-31 15:53:46 UTC) #3
glotov
Thanks for the review, I am waiting for the new mocks that were promised yesterday.
7 years, 10 months ago (2013-01-31 16:39:49 UTC) #4
Nikita (slow)
On 2013/01/31 16:39:49, glotov wrote: > Thanks for the review, I am waiting for the ...
7 years, 10 months ago (2013-02-01 12:50:00 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/glotov@chromium.org/12084042/1
7 years, 10 months ago (2013-02-01 16:41:10 UTC) #6
commit-bot: I haz the power
7 years, 10 months ago (2013-02-01 16:41:13 UTC) #7
Presubmit check for 12084042-1 failed and returned exit status 1.


Running presubmit commit checks ...
Traceback (most recent call last):
  File "/b/commit-queue/verification/presubmit_shim.py", line 43, in <module>
    sys.exit(presubmit_support.Main(argv))
  File "/b/depot_tools/presubmit_support.py", line 1259, in Main
    rietveld_obj)
  File "/b/depot_tools/presubmit_support.py", line 1107, in DoPresubmitChecks
    results += executer.ExecPresubmitScript(presubmit_script, filename)
  File "/b/depot_tools/presubmit_support.py", line 1024, in ExecPresubmitScript
    result = eval(function_name + '(*__args)', context)
  File "<string>", line 1, in <module>
  File "<string>", line 19, in CheckChangeOnCommit
  File "<string>", line 42, in _CommonChecks
  File
"/b/commit-queue/workdir/chromium/ui/resources/resource_check/resource_scale_factors.py",
line 85, in RunChecks
    base_dimensions = ImageSize(base_image)
  File
"/b/commit-queue/workdir/chromium/ui/resources/resource_check/resource_scale_factors.py",
line 47, in ImageSize
    assert data[:8] == '\x89PNG\r\n\x1A\n' and data[12:16] == 'IHDR'
AssertionError

Powered by Google App Engine
This is Rietveld 408576698