Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4575)

Unified Diff: chrome/common/extensions/web_intents_handler.cc

Issue 12084034: Change manifest handler interface to always (implicitly) pass the entire manifest to handlers. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: tts, TODO Created 7 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/common/extensions/web_intents_handler.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/common/extensions/web_intents_handler.cc
diff --git a/chrome/common/extensions/web_intents_handler.cc b/chrome/common/extensions/web_intents_handler.cc
index 28d8b954a9b080d3e00259cf67dbd889a0003621..d264394afb6777670e2daf3271f53445bc480573 100644
--- a/chrome/common/extensions/web_intents_handler.cc
+++ b/chrome/common/extensions/web_intents_handler.cc
@@ -10,6 +10,7 @@
#include "base/utf_string_conversions.h"
#include "base/values.h"
#include "chrome/common/extensions/extension_manifest_constants.h"
+#include "chrome/common/extensions/manifest.h"
#include "extensions/common/error_utils.h"
#include "webkit/glue/web_intent_service_data.h"
@@ -167,12 +168,10 @@ WebIntentsHandler::WebIntentsHandler() {
WebIntentsHandler::~WebIntentsHandler() {
}
-bool WebIntentsHandler::Parse(const base::Value* value,
- Extension* extension,
- string16* error) {
+bool WebIntentsHandler::Parse(Extension* extension, string16* error) {
scoped_ptr<WebIntentsInfo> info(new WebIntentsInfo);
const DictionaryValue* all_services = NULL;
- if (!value->GetAsDictionary(&all_services)) {
+ if (!extension->manifest()->GetDictionary(keys::kIntents, &all_services)) {
*error = ASCIIToUTF16(errors::kInvalidIntents);
return false;
}
« no previous file with comments | « chrome/common/extensions/web_intents_handler.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698