Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6728)

Unified Diff: chrome/common/extensions/web_accessible_resources_handler.cc

Issue 12084034: Change manifest handler interface to always (implicitly) pass the entire manifest to handlers. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: tts, TODO Created 7 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/common/extensions/web_accessible_resources_handler.cc
diff --git a/chrome/common/extensions/web_accessible_resources_handler.cc b/chrome/common/extensions/web_accessible_resources_handler.cc
index 7b135d98f114c562c379ac1d75ee190d0c19787f..f6e171014a42510a46dca6e862b552aad4bf01cc 100644
--- a/chrome/common/extensions/web_accessible_resources_handler.cc
+++ b/chrome/common/extensions/web_accessible_resources_handler.cc
@@ -9,6 +9,7 @@
#include "base/utf_string_conversions.h"
#include "base/values.h"
#include "chrome/common/extensions/extension_manifest_constants.h"
+#include "chrome/common/extensions/manifest.h"
#include "extensions/common/error_utils.h"
namespace extensions {
@@ -60,12 +61,12 @@ WebAccessibleResourcesHandler::WebAccessibleResourcesHandler() {
WebAccessibleResourcesHandler::~WebAccessibleResourcesHandler() {
}
-bool WebAccessibleResourcesHandler::Parse(const base::Value* value,
- Extension* extension,
+bool WebAccessibleResourcesHandler::Parse(Extension* extension,
string16* error) {
scoped_ptr<WebAccessibleResourcesInfo> info(new WebAccessibleResourcesInfo);
const ListValue* list_value = NULL;
- if (!value->GetAsList(&list_value)) {
+ if (!extension->manifest()->GetList(keys::kWebAccessibleResources,
+ &list_value)) {
*error = ASCIIToUTF16(errors::kInvalidWebAccessibleResourcesList);
return false;
}
« no previous file with comments | « chrome/common/extensions/web_accessible_resources_handler.h ('k') | chrome/common/extensions/web_intents_handler.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698