chrome/common/extensions/manifest.h - Issue 12084034: Change manifest handler interface to always (implicitly) pass the entire manifest to handlers.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/common/extensions/manifest.h

Issue 12084034: Change manifest handler interface to always (implicitly) pass the entire manifest to handlers. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: tts, TODO Created 7 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/common/extensions/manifest.h

diff --git a/chrome/common/extensions/manifest.h b/chrome/common/extensions/manifest.h

index 6c8d6129156c628f480a68f38d0e8620cbb74d9d..7472c2944814c645671217bcc77ac22c07b58605 100644

--- a/chrome/common/extensions/manifest.h

+++ b/chrome/common/extensions/manifest.h

@@ -61,7 +61,11 @@ class Manifest {

bool GetString(const std::string& path, std::string* out_value) const;

bool GetString(const std::string& path, string16* out_value) const;

bool GetDictionary(const std::string& path,

+ const base::DictionaryValue** out_value) const;

+ bool GetDictionary(const std::string& path,

base::DictionaryValue** out_value) const;

+ bool GetList(const std::string& path,

+ const base::ListValue** out_value) const;

bool GetList(const std::string& path, base::ListValue** out_value) const;

// Returns a new Manifest equal to this one, passing ownership to

« no previous file with comments | « chrome/common/extensions/extension.cc ('k') | chrome/common/extensions/manifest.cc » ('j') | no next file with comments »