Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3581)

Unified Diff: chrome/common/extensions/api/speech/tts_engine_manifest_handler.cc

Issue 12084034: Change manifest handler interface to always (implicitly) pass the entire manifest to handlers. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: tts, TODO Created 7 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/common/extensions/api/speech/tts_engine_manifest_handler.cc
diff --git a/chrome/common/extensions/api/speech/tts_engine_manifest_handler.cc b/chrome/common/extensions/api/speech/tts_engine_manifest_handler.cc
index ac0bd6d8a51c54e5575c74863141a16e2edfcffc..afd88bbc50658803aee6be0fea091a7cbcdddcc4 100644
--- a/chrome/common/extensions/api/speech/tts_engine_manifest_handler.cc
+++ b/chrome/common/extensions/api/speech/tts_engine_manifest_handler.cc
@@ -9,6 +9,7 @@
#include "base/utf_string_conversions.h"
#include "base/values.h"
#include "chrome/common/extensions/extension_manifest_constants.h"
+#include "chrome/common/extensions/manifest.h"
#include "extensions/common/error_utils.h"
#include "ui/base/l10n/l10n_util.h"
@@ -45,11 +46,10 @@ TtsEngineManifestHandler::TtsEngineManifestHandler() {
TtsEngineManifestHandler::~TtsEngineManifestHandler() {
}
-bool TtsEngineManifestHandler::Parse(const base::Value* value,
- Extension* extension, string16* error) {
+bool TtsEngineManifestHandler::Parse(Extension* extension, string16* error) {
scoped_ptr<TtsVoices> info(new TtsVoices);
const DictionaryValue* tts_dict = NULL;
- if (!value->GetAsDictionary(&tts_dict)) {
+ if (!extension->manifest()->GetDictionary(keys::kTtsEngine, &tts_dict)) {
*error = ASCIIToUTF16(errors::kInvalidTts);
return false;
}
« no previous file with comments | « chrome/common/extensions/api/speech/tts_engine_manifest_handler.h ('k') | chrome/common/extensions/extension.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698