chrome/common/extensions/api/extension_action/script_badge_manifest_unittest.cc - Issue 12084034: Change manifest handler interface to always (implicitly) pass the entire manifest to handlers.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/common/extensions/api/extension_action/script_badge_manifest_unittest.cc

Issue 12084034: Change manifest handler interface to always (implicitly) pass the entire manifest to handlers. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 7 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/common/extensions/api/extension_action/script_badge_handler.cc ('k') | chrome/common/extensions/api/file_handlers/file_handlers_parser.h » ('j') | chrome/common/extensions/extension.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/common/extensions/api/extension_action/script_badge_manifest_unittest.cc

diff --git a/chrome/common/extensions/api/extension_action/script_badge_manifest_unittest.cc b/chrome/common/extensions/api/extension_action/script_badge_manifest_unittest.cc

index 98b5f17bcc2e9a5291ed02a62aefa5f6dbea3521..9e82d4b566dc2b6db5c1724551d75f0dfe93766a 100644

--- a/chrome/common/extensions/api/extension_action/script_badge_manifest_unittest.cc

+++ b/chrome/common/extensions/api/extension_action/script_badge_manifest_unittest.cc

@@ -8,6 +8,7 @@

#include "chrome/common/extensions/extension_constants.h"

#include "chrome/common/extensions/extension_icon_set.h"

#include "chrome/common/extensions/extension_manifest_constants.h"

+#include "chrome/common/extensions/feature_switch.h"

#include "chrome/common/extensions/manifest_handler.h"

#include "chrome/common/extensions/manifest_tests/extension_manifest_test.h"

#include "testing/gmock/include/gmock/gmock.h"

@@ -31,10 +32,16 @@ std::vector<Extension::InstallWarning> StripMissingFlagWarning(

class ScriptBadgeManifestTest : public ExtensionManifestTest {

protected:

+ ScriptBadgeManifestTest()

+ : enable_script_badges_(FeatureSwitch::script_badges(), true) {

+ }

virtual void SetUp() OVERRIDE {

ManifestHandler::Register(extension_manifest_keys::kScriptBadge,

new ScriptBadgeHandler);

}

+ private:

+ FeatureSwitch::ScopedOverride enable_script_badges_;

};

} // namespace