Change manifest handler interface to always (implicitly) pass the entire manifest to handlers.

chrome/common/extensions/manifest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/common/extensions/manifest.h"
 
 #include "base/basictypes.h"
 #include "base/lazy_instance.h"
 #include "base/logging.h"
 #include "base/string_split.h"
@@ skipping 106 matching lines @@
     const std::string& path, std::string* out_value) const {
   return CanAccessPath(path) && value_->GetString(path, out_value);
 }
 
 bool Manifest::GetString(
     const std::string& path, string16* out_value) const {
   return CanAccessPath(path) && value_->GetString(path, out_value);
 }
 
 bool Manifest::GetDictionary(
+    const std::string& path, const DictionaryValue** out_value) const {
+  return CanAccessPath(path) && value_->GetDictionary(path, out_value);

[Matt Perry, 2013/01/29 00:58:47]

implement these in terms of the non-const versions (use temporaries)

[Yoyo Zhou, 2013/01/29 04:32:42]

Done - let me know if this casting looks reasonable.

+}
+
+bool Manifest::GetDictionary(
     const std::string& path, DictionaryValue** out_value) const {
   return CanAccessPath(path) && value_->GetDictionary(path, out_value);
 }
 
 bool Manifest::GetList(
+    const std::string& path, const ListValue** out_value) const {
+  return CanAccessPath(path) && value_->GetList(path, out_value);
+}
+
+bool Manifest::GetList(
     const std::string& path, ListValue** out_value) const {
   return CanAccessPath(path) && value_->GetList(path, out_value);
 }
 
 Manifest* Manifest::DeepCopy() const {
   Manifest* manifest = new Manifest(
       location_, scoped_ptr<DictionaryValue>(value_->DeepCopy()));
   manifest->set_extension_id(extension_id_);
   return manifest;
 }
@@ skipping 28 matching lines @@
       BaseFeatureProvider::GetManifestFeatures()->GetFeature(key);
   if (!feature)
     return true;
 
   return feature->IsAvailableToManifest(
       extension_id_, type_, Feature::ConvertLocation(location_),
       GetManifestVersion()).is_available();
 }
 
 }  // namespace extensions