Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6076)

Unified Diff: chrome/test/base/web_ui_browsertest.h

Issue 12084029: Simplify how TestChromeWebUIControllerFactory is registered now that multiple WebUIControllerFactor… (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: sync to head Created 7 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/test/base/web_ui_browsertest.h
===================================================================
--- chrome/test/base/web_ui_browsertest.h (revision 179158)
+++ chrome/test/base/web_ui_browsertest.h (working copy)
@@ -2,8 +2,8 @@
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
-#ifndef CHROME_BROWSER_UI_WEBUI_WEB_UI_BROWSERTEST_H_
-#define CHROME_BROWSER_UI_WEBUI_WEB_UI_BROWSERTEST_H_
+#ifndef CHROME_TEST_BASE_WEB_UI_BROWSERTEST_H_
+#define CHROME_TEST_BASE_WEB_UI_BROWSERTEST_H_
#include <string>
#include <vector>
@@ -24,6 +24,7 @@
class WebUIMessageHandler;
}
+class TestChromeWebUIControllerFactory;
class WebUITestHandler;
// This macro simplifies the declaration of simple javascript unit tests.
@@ -128,12 +129,6 @@
virtual void SetUpOnMainThread() OVERRIDE;
virtual void CleanUpOnMainThread() OVERRIDE;
- // Set up test path & override for |kDummyURL|.
- virtual void SetUpInProcessBrowserTestFixture() OVERRIDE;
-
- // Tear down override for |kDummyURL|.
- virtual void TearDownInProcessBrowserTestFixture() OVERRIDE;
-
// Set a WebUI instance to run tests on.
void SetWebUIInstance(content::WebUI* web_ui);
@@ -198,6 +193,8 @@
// When this is non-NULL, this is The WebUI instance used for testing.
// Otherwise the selected tab's web_ui is used.
content::WebUI* override_selected_web_ui_;
+
+ scoped_ptr<TestChromeWebUIControllerFactory> test_factory_;
};
-#endif // CHROME_BROWSER_UI_WEBUI_WEB_UI_BROWSERTEST_H_
+#endif // CHROME_TEST_BASE_WEB_UI_BROWSERTEST_H_
« no previous file with comments | « chrome/test/base/test_chrome_web_ui_controller_factory_browsertest.cc ('k') | chrome/test/base/web_ui_browsertest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698