Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1831)

Unified Diff: chrome/test/base/test_chrome_web_ui_controller_factory.cc

Issue 12084029: Simplify how TestChromeWebUIControllerFactory is registered now that multiple WebUIControllerFactor… (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: sync to head Created 7 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/test/base/test_chrome_web_ui_controller_factory.cc
===================================================================
--- chrome/test/base/test_chrome_web_ui_controller_factory.cc (revision 179158)
+++ chrome/test/base/test_chrome_web_ui_controller_factory.cc (working copy)
@@ -2,7 +2,7 @@
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
-#include "chrome/browser/ui/webui/test_chrome_web_ui_controller_factory.h"
+#include "chrome/test/base/test_chrome_web_ui_controller_factory.h"
#include "chrome/browser/profiles/profile.h"
#include "content/public/browser/web_contents.h"
@@ -22,14 +22,14 @@
void TestChromeWebUIControllerFactory::AddFactoryOverride(
const std::string& host, WebUIProvider* provider) {
- DCHECK_EQ(0U, GetInstance()->factory_overrides_.count(host));
- GetInstance()->factory_overrides_[host] = provider;
+ DCHECK_EQ(0U, factory_overrides_.count(host));
+ factory_overrides_[host] = provider;
}
void TestChromeWebUIControllerFactory::RemoveFactoryOverride(
const std::string& host) {
- DCHECK_EQ(1U, GetInstance()->factory_overrides_.count(host));
- GetInstance()->factory_overrides_.erase(host);
+ DCHECK_EQ(1U, factory_overrides_.count(host));
+ factory_overrides_.erase(host);
}
WebUI::TypeID TestChromeWebUIControllerFactory::GetWebUIType(
@@ -48,12 +48,6 @@
ChromeWebUIControllerFactory::CreateWebUIControllerForURL(web_ui, url);
}
-TestChromeWebUIControllerFactory*
- TestChromeWebUIControllerFactory::GetInstance() {
- return static_cast<TestChromeWebUIControllerFactory*>(
- ChromeWebUIControllerFactory::GetInstance());
-}
-
TestChromeWebUIControllerFactory::WebUIProvider*
TestChromeWebUIControllerFactory::GetWebUIProvider(
Profile* profile, const GURL& url) const {

Powered by Google App Engine
This is Rietveld 408576698