content/test/data/accessibility/iframe-coordinates.html - Issue 12084028: Fix accessibility coordinates within iframes.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: content/test/data/accessibility/iframe-coordinates.html

Issue 12084028: Fix accessibility coordinates within iframes. (Closed) Base URL: http://git.chromium.org/chromium/src.git@master

Patch Set: Created 7 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« content/browser/accessibility/dump_accessibility_tree_helper_mac.mm ('K') | « content/browser/accessibility/dump_accessibility_tree_helper_mac.mm ('k') | content/test/data/accessibility/iframe-coordinates-expected-mac.txt » ('j') | content/test/data/accessibility/iframe-coordinates-expected-mac.txt » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <!doctype html>

	2 <!--

	3 @MAC-DENY:title*

	4 @MAC-DENY:value*

	5 @MAC-ALLOW:position*

	6 @MAC-ALLOW:size*

	7

	8 @WIN-DENY:title*

	9 @WIN-ALLOW:location*

	10 @WIN-ALLOW:size*

	11 -->

	12 <html>

	13 <head>

	14 </head>

	15 <body style="margin: 0; padding: 0;">

	16

	17 <div style="width: 300px; height: 100px;">

	18 <button style="margin: 20px; border: 0; width: 260px; height: 60px">

	19 Button

	20 </button>

	21 </div>

	22

	23 <div style="width: 300px; height: 100px;">

	24 <button style="margin: 20px; border: 0; width: 260px; height: 60px">

	25 Button

	26 </button>

	27 </div>

	28

	29 <div>

	30 <iframe id="frame1" style="border: 0; width: 300px; height: 100px;">

	31 </iframe>

	32 </div>

	33

	34 <div>

	35 <iframe id="frame2" style="border: 0; width: 150px; height: 50px;">
	aboxhall 2013/01/29 01:52:40 Why is this iframe half the size of everything els Why is this iframe half the size of everything else? dmazzoni 2013/01/29 16:51:50 It's deliberately scrolled also (see below) - so w Show quoted text On 2013/01/29 01:52:40, aboxhall wrote: > Why is this iframe half the size of everything else? It's deliberately scrolled also (see below) - so we can test the coordinates of an element when they're inside a scrolled iframe. aboxhall 2013/01/29 17:43:26 Right, I somehow forgot that it has to be smaller Show quoted text On 2013/01/29 16:51:50, Dominic Mazzoni wrote: > On 2013/01/29 01:52:40, aboxhall wrote: > > Why is this iframe half the size of everything else? > > It's deliberately scrolled also (see below) - so we can test the coordinates of > an element when they're inside a scrolled iframe. Right, I somehow forgot that it has to be smaller than the contents in order to scroll, duh. It really does get quite tricky verifying the numbers when it starts to be things like "AXButton position=(-130, 274)" - could we perhaps keep things in multiples of 100, e.g. have the standard div size be 300x200, have this be 200x100, scroll by 100/100? Then when there's an offset of 20px it'll be obvious where that's come from.
	36 </iframe>

	37 </div>

	38

	39 <script>

	40 var frameCode =

	41 '<body style="margin: 0; padding: 0;">\n' +

	42 '<div style="width: 300px; height: 100px;">\n' +

	43 ' <button style="margin: 20px; border: 0; width: 260px; height: 60px">\n' +

	44 ' Button\n' +

	45 ' </button>\n' +

	46 '</div>\n' +

	47 '</body>\n';

	48

	49 function writeFrameCode(frame) {

	50 var doc = frame.contentWindow.document;

	51 doc.open();

	52 doc.write(frameCode);

	53 doc.close();

	54 }

	55

	56 var frame1 = document.getElementById('frame1');

	57 writeFrameCode(frame1);

	58

	59 var frame2 = document.getElementById('frame2');

	60 writeFrameCode(frame2);

	61 frame2.contentWindow.scrollTo(150, 50);

	62 </script>

	63

	64 </body>

	65 </html>

OLD	NEW