content/test/data/accessibility/iframe-coordinates-expected-mac.txt - Issue 12084028: Fix accessibility coordinates within iframes.

Side by Side Diff: content/test/data/accessibility/iframe-coordinates-expected-mac.txt

Issue 12084028: Fix accessibility coordinates within iframes. (Closed) Base URL: http://git.chromium.org/chromium/src.git@master

Patch Set: Created 7 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
(Empty)
	1 AXWebArea position=(0, 0) size=(800, 600) scroll=(0, 0)

	2 AXGroup position=(0, 0) size=(300, 100)

	3 AXButton position=(20, 20) size=(260, 60)

	4 AXGroup position=(0, 100) size=(300, 100)

	5 AXButton position=(20, 120) size=(260, 60)

	6 AXGroup position=(0, 200) size=(800, 104)
	aboxhall 2013/01/29 01:52:40 Where are these 4px coming from? Where are these 4px coming from? dmazzoni 2013/01/29 16:51:50 Borders, margins, and padding, oh my! Borders, mar Show quoted text On 2013/01/29 01:52:40, aboxhall wrote: > Where are these 4px coming from? Borders, margins, and padding, oh my! Borders, margins, and padding, oh my! If I fix this, the html won't fit in 80 columns without splitting things into style declarations in the header. I'm just not sure which is more or less readable, round numbers in the expectations or more compact html. aboxhall 2013/01/29 17:43:26 Ok - I was just confused because it looked like yo Show quoted text On 2013/01/29 16:51:50, Dominic Mazzoni wrote: > On 2013/01/29 01:52:40, aboxhall wrote: > > Where are these 4px coming from? > > Borders, margins, and padding, oh my! > Borders, margins, and padding, oh my! > > If I fix this, the html won't fit in 80 columns without splitting things into > style declarations in the header. I'm just not sure which is more or less > readable, round numbers in the expectations or more compact html. Ok - I was just confused because it looked like you'd set borders, margin and padding all to zero at some point. I think it probably would be easier to put a style block in the header to keep all the numbers round - I really did have to spend quite a long time (although it didn't help that I was on the bus and kept getting distracted) trying to make sure everything added up. dmazzoni 2013/01/29 18:51:25 Seems reasonable. I fixed it to use nice, round nu Show quoted text On 2013/01/29 17:43:26, aboxhall wrote: > On 2013/01/29 16:51:50, Dominic Mazzoni wrote: > > On 2013/01/29 01:52:40, aboxhall wrote: > > > Where are these 4px coming from? > > > > Borders, margins, and padding, oh my! > > Borders, margins, and padding, oh my! > > > > If I fix this, the html won't fit in 80 columns without splitting things into > > style declarations in the header. I'm just not sure which is more or less > > readable, round numbers in the expectations or more compact html. > > Ok - I was just confused because it looked like you'd set borders, margin and > padding all to zero at some point. I think it probably would be easier to put a > style block in the header to keep all the numbers round - I really did have to > spend quite a long time (although it didn't help that I was on the bus and kept > getting distracted) trying to make sure everything added up. Seems reasonable. I fixed it to use nice, round numbers.
	7 AXUnknown position=(0, 200) size=(300, 100)

	8 AXUnknown position=(0, 0) size=(0, 0)

	9 AXWebArea position=(0, 200) size=(300, 100) scroll=(0, 0)

	10 AXGroup position=(0, 200) size=(300, 100)

	11 AXButton position=(20, 220) size=(260, 60)

	12 AXGroup position=(0, 304) size=(800, 54)

	13 AXUnknown position=(0, 304) size=(150, 50)

	14 AXUnknown position=(0, 0) size=(0, 0)

	15 AXWebArea position=(0, 304) size=(300, 100) scroll=(150, 50)
	aboxhall 2013/01/29 19:53:47 Where did the scroll coordinates go? Where did the scroll coordinates go? dmazzoni 2013/01/29 21:02:07 Oh, that was left over from my own internal debugg Show quoted text On 2013/01/29 19:53:47, aboxhall wrote: > Where did the scroll coordinates go? Oh, that was left over from my own internal debugging. Those aren't actually exposed in the native API in a straightforward way so it doesn't make sense to include them here. Maybe we can expose those on the AXScrollBars at some point, but either way that's outside of the scope of this change.
	16 AXGroup position=(-150, 254) size=(300, 100)

	17 AXButton position=(-130, 274) size=(260, 60)

	18 AXScrollBar position=(0, 0) size=(0, 0)

	19 AXScrollBar position=(0, 0) size=(0, 0)

OLD	NEW

« content/test/data/accessibility/iframe-coordinates.html ('K') | « content/test/data/accessibility/iframe-coordinates.html ('k') | no next file » | no next file with comments »