Use WebInputElement.isCheckbox() and isRadioButton() API being exposed by https://bugs.webkit.org/s…

chrome/renderer/autofill/form_autofill_util.cc

Index: chrome/renderer/autofill/form_autofill_util.cc
diff --git a/chrome/renderer/autofill/form_autofill_util.cc b/chrome/renderer/autofill/form_autofill_util.cc
index 9b5cd05aac90560a9732959c0777e0d44bbf2e44..c04954160f8158845c0ee5992fff897e5dd7d9b8 100644
--- a/chrome/renderer/autofill/form_autofill_util.cc
+++ b/chrome/renderer/autofill/form_autofill_util.cc
@@ -574,21 +574,14 @@ bool IsSelectElement(const WebFormControlElement& element) {
 }
 
 bool IsCheckableElement(const WebInputElement* element) {
-  // Is static for improving performance.
-  CR_DEFINE_STATIC_LOCAL(WebString, kRadio, ("radio"));
-  CR_DEFINE_STATIC_LOCAL(WebString, kCheckbox, ("checkbox"));
-
   if (!element)
     return false;
 
-  WebString formControlType = element->formControlType();
-  return formControlType == kCheckbox || formControlType == kRadio;
+  return element->isCheckbox() || element->isRadioButton();
 }
 
 bool IsAutofillableInputElement(const WebInputElement* element) {
-  // TODO(ramankk): Uncomment IsCheckableElement part once we have solution
-  // for the observed performance regression.
-  return IsTextInput(element); // || IsCheckableElement(element);
+  return IsTextInput(element) || IsCheckableElement(element);

[Albert Bodenhamer, 2013/01/28 19:16:28]

This CL is likely to fix the performance regression, but it MIGHT still be
better to put uncommenting your code into another CL so we have more control if
we've still missed it somehow.

[Raman Kakilate, 2013/01/28 20:03:00]

All the test data file changes in this CL depend on this line change itself. If
I leave this commented out, then the only change left would be
IsCheckableElement() function definition.

I think having them in single CL is easier.

 }
 
 const string16 GetFormIdentifier(const WebFormElement& form) {