Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(6)

Issue 1208333003: Run crash test only on release builds because it's slow on debug (Closed)

Created:
4 years, 10 months ago by kochi
Modified:
4 years, 10 months ago
Reviewers:
hayato
CC:
blink-reviews, eae
Target Ref:
refs/remotes/origin/master
Project:
blink
Visibility:
Public.

Description

Run crashing test only on release builds because it's slow on debug fast/dom/shadow/focus-controller-recursion-crash.html was marked SLOW, but it would be suffice to run it on release builds to catch any regression. Disable the test on debug builds. Original CL: https://codereview.chromium.org/1204213002/ SLOW marked at: https://codereview.chromium.org/1208213002/ BUG=445194 TEST=check if the test is run on release, skipped on debug Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=197889

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -2 lines) Patch
M LayoutTests/SlowTests View 1 chunk +0 lines, -2 lines 0 comments Download
M LayoutTests/TestExpectations View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
kochi
PTAL
4 years, 10 months ago (2015-06-26 03:44:34 UTC) #2
hayato
LGTM. Could you make the subject of this CL more specific?
4 years, 10 months ago (2015-06-26 04:03:51 UTC) #3
kochi
On 2015/06/26 04:03:51, hayato wrote: > LGTM. > > Could you make the subject of ...
4 years, 10 months ago (2015-06-26 04:13:00 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1208333003/1
4 years, 10 months ago (2015-06-26 04:13:28 UTC) #6
commit-bot: I haz the power
4 years, 10 months ago (2015-06-26 05:13:06 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=197889

Powered by Google App Engine
This is Rietveld 408576698