Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(33)

Side by Side Diff: Source/core/dom/Document.cpp

Issue 1208303003: Revert of Fix leaking AXNodeObjects when sub document detaches (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
3 * (C) 1999 Antti Koivisto (koivisto@kde.org) 3 * (C) 1999 Antti Koivisto (koivisto@kde.org)
4 * (C) 2001 Dirk Mueller (mueller@kde.org) 4 * (C) 2001 Dirk Mueller (mueller@kde.org)
5 * (C) 2006 Alexey Proskuryakov (ap@webkit.org) 5 * (C) 2006 Alexey Proskuryakov (ap@webkit.org)
6 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2011, 2012 Apple Inc. All r ights reserved. 6 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2011, 2012 Apple Inc. All r ights reserved.
7 * Copyright (C) 2008, 2009 Torch Mobile Inc. All rights reserved. (http://www.t orchmobile.com/) 7 * Copyright (C) 2008, 2009 Torch Mobile Inc. All rights reserved. (http://www.t orchmobile.com/)
8 * Copyright (C) 2008, 2009, 2011, 2012 Google Inc. All rights reserved. 8 * Copyright (C) 2008, 2009, 2011, 2012 Google Inc. All rights reserved.
9 * Copyright (C) 2010 Nokia Corporation and/or its subsidiary(-ies) 9 * Copyright (C) 2010 Nokia Corporation and/or its subsidiary(-ies)
10 * Copyright (C) Research In Motion Limited 2010-2011. All rights reserved. 10 * Copyright (C) Research In Motion Limited 2010-2011. All rights reserved.
(...skipping 2167 matching lines...) Expand 10 before | Expand all | Expand 10 after
2178 m_activeHoverElement = nullptr; 2178 m_activeHoverElement = nullptr;
2179 m_autofocusElement = nullptr; 2179 m_autofocusElement = nullptr;
2180 2180
2181 if (m_focusedElement.get()) { 2181 if (m_focusedElement.get()) {
2182 RefPtrWillBeRawPtr<Element> oldFocusedElement = m_focusedElement; 2182 RefPtrWillBeRawPtr<Element> oldFocusedElement = m_focusedElement;
2183 m_focusedElement = nullptr; 2183 m_focusedElement = nullptr;
2184 if (frameHost()) 2184 if (frameHost())
2185 frameHost()->chromeClient().focusedNodeChanged(oldFocusedElement.get (), nullptr); 2185 frameHost()->chromeClient().focusedNodeChanged(oldFocusedElement.get (), nullptr);
2186 } 2186 }
2187 2187
2188 if (this == &axObjectCacheOwner()) { 2188 if (this == &axObjectCacheOwner())
2189 clearAXObjectCache(); 2189 clearAXObjectCache();
2190 } else if (AXObjectCache* cache = existingAXObjectCache()) {
2191 for (Node& node : NodeTraversal::descendantsOf(*this)) {
2192 cache->remove(&node);
2193 }
2194 }
2195 2190
2196 m_layoutView = nullptr; 2191 m_layoutView = nullptr;
2197 ContainerNode::detach(context); 2192 ContainerNode::detach(context);
2198 2193
2199 styleEngine().didDetach(); 2194 styleEngine().didDetach();
2200 2195
2201 frameHost()->eventHandlerRegistry().documentDetached(*this); 2196 frameHost()->eventHandlerRegistry().documentDetached(*this);
2202 2197
2203 // If this Document is associated with a live DocumentLoader, the 2198 // If this Document is associated with a live DocumentLoader, the
2204 // DocumentLoader will take care of clearing the FetchContext. Deferring 2199 // DocumentLoader will take care of clearing the FetchContext. Deferring
(...skipping 3566 matching lines...) Expand 10 before | Expand all | Expand 10 after
5771 #ifndef NDEBUG 5766 #ifndef NDEBUG
5772 using namespace blink; 5767 using namespace blink;
5773 void showLiveDocumentInstances() 5768 void showLiveDocumentInstances()
5774 { 5769 {
5775 WeakDocumentSet& set = liveDocumentSet(); 5770 WeakDocumentSet& set = liveDocumentSet();
5776 fprintf(stderr, "There are %u documents currently alive:\n", set.size()); 5771 fprintf(stderr, "There are %u documents currently alive:\n", set.size());
5777 for (Document* document : set) 5772 for (Document* document : set)
5778 fprintf(stderr, "- Document %p URL: %s\n", document, document->url().str ing().utf8().data()); 5773 fprintf(stderr, "- Document %p URL: %s\n", document, document->url().str ing().utf8().data());
5779 } 5774 }
5780 #endif 5775 #endif
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698