Issue 1208303003: Revert of Fix leaking AXNodeObjects when sub document detaches

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1208303003: Revert of Fix leaking AXNodeObjects when sub document detaches (Closed)

Created:
4 years, 10 months ago by amineer_google

Modified:
4 years, 10 months ago

Reviewers:
haraken, keishi, dmazzoni

CC:
blink-reviews, blink-reviews-dom_chromium.org, dglazkov+blink, sof, eae+blinkwatch, rwlbuis

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Target Ref:
refs/heads/master

Project:
blink

Visibility:
Public.

Revert of Fix leaking AXNodeObjects when sub document detaches (patchset #1 id:1 of https://codereview.chromium.org/1207613004/) Reason for revert: Top crasher in canary - bug 504315. Original issue's description: > Fix leaking AXNodeObjects when sub document detaches > > Node::willBeDeletedFromDocument() is called after the Document has been detached so axObjectCacheOwner() is already disconnected and the node was failing to be removed from the cache. > > Test will be added in https://codereview.chromium.org/1202263005/ > > BUG=502782 > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=197755 TBR=dmazzoni@chromium.org,haraken@chromium.org,keishi@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=502782 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=197924