Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(172)

Issue 1208273003: Stocks.apk should have icons when run offline (Closed)

Created:
5 years, 5 months ago by abarth-chromium
Modified:
5 years, 5 months ago
Reviewers:
eseidel1
CC:
mojo-reviews_chromium.org, gregsimon, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, jackson_old, yzshen+watch_chromium.org, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
git@github.com:domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Stocks.apk should have icons when run offline This CL adds the concept of a root asset bundle to Sky. If the Sky app was launched from a bundle, the root bundle is that bundle. This CL teaches icon.dart to default to loading icons out of the root bundle, if a root bundle exists. The next result is that Stocks has icons when run offline because the icons are present in stock's skyx bundle. TBR=eseidel@google.com Committed: https://chromium.googlesource.com/external/mojo/+/71f1f5ba310c7a13ace30b1c1a66aefecc381e02

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+59 lines, -15 lines) Patch
M sky/engine/bindings/sky_internals.dart View 1 chunk +3 lines, -2 lines 0 comments Download
M sky/sdk/lib/mojo/asset_bundle.dart View 2 chunks +13 lines, -0 lines 0 comments Download
M sky/sdk/lib/widgets/icon.dart View 1 chunk +8 lines, -2 lines 0 comments Download
M sky/shell/ui/engine.cc View 1 chunk +2 lines, -1 line 0 comments Download
M sky/shell/ui/internals.h View 1 chunk +6 lines, -2 lines 0 comments Download
M sky/shell/ui/internals.cc View 4 chunks +20 lines, -6 lines 0 comments Download
M sky/viewer/internals.cc View 2 chunks +7 lines, -2 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
abarth-chromium
5 years, 5 months ago (2015-07-02 20:39:16 UTC) #1
abarth-chromium
5 years, 5 months ago (2015-07-02 20:47:18 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
71f1f5ba310c7a13ace30b1c1a66aefecc381e02 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698