Add supported checks to the SVG library, and library cleanup.

Add supported checks to the SVG library, and library cleanup.

BUG=

Committed: https://code.google.com/p/dart/source/detail?r=17994

[Emily Fortuna, 2013-02-01 18:12:58]

Take 2 of the last CL. It's identical except where marked by the comment. It
compiles with dartium now, too.

https://codereview.chromium.org/12082122/diff/1/tools/dom/scripts/generator.py
File tools/dom/scripts/generator.py (right):

https://codereview.chromium.org/12082122/diff/1/tools/dom/scripts/generator.p...
tools/dom/scripts/generator.py:29: 'SVGExternalResourcesRequired',
In the previous version of this, I had removed this line and line 32, so that
they were no longer "pure interfaces" This caused compilation problems on the
dartium end, and as I see now, is not necessary for this change to work.

[blois, 2013-02-01 18:24:19]

https://codereview.chromium.org/12082122/diff/1/tests/html/html.status
File tests/html/html.status (right):

https://codereview.chromium.org/12082122/diff/1/tests/html/html.status#newcode88
tests/html/html.status:88: storage_test: Fail, Pas
Pass?

https://codereview.chromium.org/12082122/diff/1/tests/html/svgelement2_test.dart
File tests/html/svgelement2_test.dart (right):

https://codereview.chromium.org/12082122/diff/1/tests/html/svgelement2_test.d...
tests/html/svgelement2_test.dart:18: group('supported', () {
This isn't really a supported test- can it be slimmed down or renamed?

https://codereview.chromium.org/12082122/diff/1/tools/dom/scripts/systemhtml.py
File tools/dom/scripts/systemhtml.py (right):

https://codereview.chromium.org/12082122/diff/1/tools/dom/scripts/systemhtml....
tools/dom/scripts/systemhtml.py:346: 'HTMLShadowElement':
ElemSupportStr('shadow'),
Should this not move into the basic_element checks?

https://codereview.chromium.org/12082122/diff/1/tools/dom/scripts/systemhtml....
tools/dom/scripts/systemhtml.py:368: dict((key,
Odd indenting

[Emily Fortuna, 2013-02-01 18:58:57]

fixed up.

https://codereview.chromium.org/12082122/diff/1/tests/html/html.status
File tests/html/html.status (right):

https://codereview.chromium.org/12082122/diff/1/tests/html/html.status#newcode88
tests/html/html.status:88: storage_test: Fail, Pas
On 2013/02/01 18:24:19, blois wrote:
> Pass?

I fixed this on my mac checkout but had forgot to fix it on my linux checkout
where I was testing dartium compilation (and where this got uploaded from).
Fixed.

https://codereview.chromium.org/12082122/diff/1/tools/dom/scripts/systemhtml.py
File tools/dom/scripts/systemhtml.py (right):

https://codereview.chromium.org/12082122/diff/1/tools/dom/scripts/systemhtml....
tools/dom/scripts/systemhtml.py:346: 'HTMLShadowElement':
ElemSupportStr('shadow'),
On 2013/02/01 18:24:19, blois wrote:
> Should this not move into the basic_element checks?

No. This uses the data in the _html_element_constructors to create the checks,
which are also elements that can be constructed with the form
"document.$dom_createElement('shadow')" only in this case you can't create a
Shadow element by passing "shadow" in.

https://codereview.chromium.org/12082122/diff/1/tools/dom/scripts/systemhtml....
tools/dom/scripts/systemhtml.py:368: dict((key,
On 2013/02/01 18:24:19, blois wrote:
> Odd indenting

This was the most readable way I saw to write this list comprehension within the
confines of 80 char. What do you suggest instead?

[blois, 2013-02-01 19:00:52]

lgtm

https://codereview.chromium.org/12082122/diff/1/tools/dom/scripts/systemhtml.py
File tools/dom/scripts/systemhtml.py (right):

https://codereview.chromium.org/12082122/diff/1/tools/dom/scripts/systemhtml....
tools/dom/scripts/systemhtml.py:368: dict((key,
On 2013/02/01 18:58:57, Emily Fortuna wrote:
> On 2013/02/01 18:24:19, blois wrote:
> > Odd indenting
> 
> This was the most readable way I saw to write this list comprehension within
the
> confines of 80 char. What do you suggest instead?

I was just looking at the 6 space indent, but realized that it's lining up with
'key'.