Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(106)

Unified Diff: media/base/yuv_convert.h

Issue 12082087: Replace or exclude MMX intrinsics in yuv_convert_simd_x86 due to lack of VS2010 support for them in… (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fix readability nit Created 7 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « media/base/simd/empty_register_state_mmx.asm ('k') | media/base/yuv_convert.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: media/base/yuv_convert.h
diff --git a/media/base/yuv_convert.h b/media/base/yuv_convert.h
index afd47d79ca1ea836a4a9852b8fb1cd224287344e..42d45265489cc0564d04c827a0591239ac6ad7a9 100644
--- a/media/base/yuv_convert.h
+++ b/media/base/yuv_convert.h
@@ -9,6 +9,16 @@
namespace media {
+// Visual Studio 2010 does not support MMX intrinsics on x64.
+// Some win64 yuv_convert code paths use SSE+MMX yasm, so without rewriting
+// them, we use yasm EmptyRegisterState_MMX in place of _mm_empty() or
+// hide the versions implemented with heavy use of MMX intrinsics.
+// TODO(wolenetz): (crbug.com/173450) Use MMX intrinsics when compiling win64
scherkus (not reviewing) 2013/01/31 23:55:27 nit: we typically format our todos w/ the bug at t
wolenetz 2013/02/01 00:57:26 Done.
+// with Visual Studio 2012?
+#if defined(ARCH_CPU_X86_64) && defined(COMPILER_MSVC)
+#define MEDIA_DO_NOT_USE_MMX_INTRINSICS
+#endif
+
// Type of YUV surface.
// The value of these enums matter as they are used to shift vertical indices.
enum YUVType {
« no previous file with comments | « media/base/simd/empty_register_state_mmx.asm ('k') | media/base/yuv_convert.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698