Replace or exclude MMX intrinsics in yuv_convert_simd_x86 due to lack of VS2010 support for them in…

media/base/yuv_convert.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef MEDIA_BASE_YUV_CONVERT_H_
 #define MEDIA_BASE_YUV_CONVERT_H_
 
 #include "base/basictypes.h"
 
 namespace media {
 
+// Visual Studio 2010 does not support MMX intrinsics on x64.
+// Some win64 yuv_convert code paths use SSE+MMX yasm, so without rewriting
+// them, we use yasm EmptyRegisterState_MMX in place of _mm_empty() or
+// hide the versions implemented with heavy use of MMX intrinsics.
+// TODO(wolenetz): Use MMX intrinsics when compiling win64 with Visual
+// Studio 2012? (crbug.com/173450)

[scherkus (not reviewing), 2013/02/01 01:13:17]

pedantic nit: use "http://crbug.com/173450: without brackets or other
punctuation 'n stuff

(there are lots of random text editors and search engines that will appreciate
your easy-to-parse URL inside comments!)

[wolenetz, 2013/02/01 02:42:07]

Done.

+#if defined(ARCH_CPU_X86_64) && defined(COMPILER_MSVC)
+#define MEDIA_DO_NOT_USE_MMX_INTRINSICS

[scherkus (not reviewing), 2013/02/01 01:13:17]

nit: it'd be clearer to negate the define i.e., USE_MMX_INTRINSICS and have it
undefined for win64 msvc

(the !defined(MEDIA_DO_NOT_USE_MMX_INTRINSICS) makes my brain hurt)

[wolenetz, 2013/02/01 02:42:07]

Done.

+#endif

[scherkus (not reviewing), 2013/02/01 01:13:17]

I believe this can be moved to the .cc

[wolenetz, 2013/02/01 02:42:07]

Done.

+
 // Type of YUV surface.
 // The value of these enums matter as they are used to shift vertical indices.
 enum YUVType {
   YV16 = 0,           // YV16 is half width and full height chroma channels.
   YV12 = 1,           // YV12 is half width and half height chroma channels.
 };
 
 // Mirror means flip the image horizontally, as in looking in a mirror.
 // Rotate happens after mirroring.
 enum Rotate {
@@ skipping 92 matching lines @@
                       int height);
 
 void ConvertNV21ToYUV(const uint8* src,
                       uint8* yplane,
                       uint8* uplane,
                       uint8* vplane,
                       int width,
                       int height);
 
 // Empty SIMD register state after calling optimized scaler functions.
-// This method is only used in unit test after calling SIMD functions.
 void EmptyRegisterState();
 
 }  // namespace media
 
 #endif  // MEDIA_BASE_YUV_CONVERT_H_