Issue 12082083: overscroll: Allow taking screenshots only in tabbed browsers.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 12082083: overscroll: Allow taking screenshots only in tabbed browsers. (Closed)

Created:
7 years, 10 months ago by sadrul

Modified:
7 years, 10 months ago

Reviewers:
sky

CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

overscroll: Allow taking screenshots only in tabbed browsers. Avoid taking screenshots for apps or panels, and make sure overscroll is allowed before taking the screenshot. BUG=160668, 172833 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=179792

Created: 7 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -2 lines)			Patch
	M	chrome/browser/ui/browser.cc	View	1	1 chunk	+1 line, -1 line	0 comments	Download
	M	content/browser/web_contents/web_contents_impl.cc	View		1 chunk	+2 lines, -1 line	0 comments	Download

Total messages: 3 (0 generated)

mtomasz

7 years, 10 months ago (2013-01-31 03:39:29 UTC) #3

On 2013/01/30 22:59:27, sky wrote:
> LGTM

Checked, and it resolved the issue 172833.