Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(92)

Unified Diff: runtime/vm/code_generator.cc

Issue 12082063: Enable correct optimized double modulo operation. (TODO: enable remainder optimization). (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 7 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/code_generator.h ('k') | runtime/vm/flow_graph_optimizer.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/code_generator.cc
===================================================================
--- runtime/vm/code_generator.cc (revision 17850)
+++ runtime/vm/code_generator.cc (working copy)
@@ -1717,4 +1717,20 @@
}
END_LEAF_RUNTIME_ENTRY
+
+double DartModulo(double left, double right) {
+ double remainder = fmod_ieee(left, right);
+ if (remainder == 0.0) {
+ // We explicitely switch to the positive 0.0 (just in case it was negative).
+ remainder = +0.0;
+ } else if (remainder < 0.0) {
+ if (right < 0) {
+ remainder -= right;
+ } else {
+ remainder += right;
+ }
+ }
+ return remainder;
+}
+
} // namespace dart
« no previous file with comments | « runtime/vm/code_generator.h ('k') | runtime/vm/flow_graph_optimizer.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698