Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(428)

Unified Diff: runtime/lib/double.cc

Issue 12082063: Enable correct optimized double modulo operation. (TODO: enable remainder optimization). (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 7 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | runtime/vm/code_generator.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/lib/double.cc
===================================================================
--- runtime/lib/double.cc (revision 17850)
+++ runtime/lib/double.cc (working copy)
@@ -7,6 +7,7 @@
#include "vm/bootstrap_natives.h"
#include "vm/bigint_operations.h"
+#include "vm/code_generator.h" // DartModulo.
#include "vm/double_conversion.h"
#include "vm/exceptions.h"
#include "vm/native_entry.h"
@@ -103,19 +104,7 @@
double left = Double::CheckedHandle(arguments->NativeArgAt(0)).value();
GET_NON_NULL_NATIVE_ARGUMENT(Double, right_object, arguments->NativeArgAt(1));
double right = right_object.value();
-
- double remainder = fmod_ieee(left, right);
- if (remainder == 0.0) {
- // We explicitely switch to the positive 0.0 (just in case it was negative).
- remainder = +0.0;
- } else if (remainder < 0) {
- if (right < 0) {
- remainder -= right;
- } else {
- remainder += right;
- }
- }
- return Double::New(remainder);
+ return Double::New(DartModulo(left, right));
}
« no previous file with comments | « no previous file | runtime/vm/code_generator.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698