Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(501)

Unified Diff: tests/lib/async/stream_controller_test.dart

Issue 12082047: Remove transformEvents and make StreamEventTransformer extend StreamTransformer. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Addressed review comments. Created 7 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « sdk/lib/async/stream_pipe.dart ('k') | tests/lib/async/stream_event_transform_test.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tests/lib/async/stream_controller_test.dart
diff --git a/tests/lib/async/stream_controller_test.dart b/tests/lib/async/stream_controller_test.dart
index 57b99e3699b5395100e8584cbcf627adbe2c6e3c..ba535d748dd3854c83da5cf0a5e1e3b3da455cca 100644
--- a/tests/lib/async/stream_controller_test.dart
+++ b/tests/lib/async/stream_controller_test.dart
@@ -93,10 +93,10 @@ testMultiController() {
expectedEvents =
new Events()..error("a")..add(42)..error("b")..add("foo")..close();
actualEvents = new Events.capture(c.stream.transform(
- new StreamTransformer.from(
- onData: (v, s) { s.signalError(new AsyncError(v)); },
- onError: (e, s) { s.add(e.error); },
- onDone: (s) {
+ new StreamTransformer(
+ handleData: (v, s) { s.signalError(new AsyncError(v)); },
+ handleError: (e, s) { s.add(e.error); },
+ handleDone: (s) {
s.add("foo");
s.close();
})));
@@ -282,10 +282,10 @@ testSingleController() {
expectedEvents =
new Events()..error("a")..add(42)..error("b")..add("foo")..close();
actualEvents = new Events.capture(c.stream.transform(
- new StreamTransformer.from(
- onData: (v, s) { s.signalError(new AsyncError(v)); },
- onError: (e, s) { s.add(e.error); },
- onDone: (s) {
+ new StreamTransformer(
+ handleData: (v, s) { s.signalError(new AsyncError(v)); },
+ handleError: (e, s) { s.add(e.error); },
+ handleDone: (s) {
s.add("foo");
s.close();
})));
« no previous file with comments | « sdk/lib/async/stream_pipe.dart ('k') | tests/lib/async/stream_event_transform_test.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698