Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(66)

Issue 12082017: Remove dependencies to 'chrome' from device/media_transfer_protocol. (Closed)

Created:
7 years, 10 months ago by kmadhusu
Modified:
7 years, 10 months ago
Reviewers:
Lei Zhang, Garret Kelly
CC:
chromium-reviews
Visibility:
Public.

Description

Remove dependencies to 'chrome' from device/media_transfer_protocol. BUG=171742 TEST=none Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=179938

Patch Set 1 #

Patch Set 2 : Addressed comments #

Total comments: 3

Patch Set 3 : Addressed comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -13 lines) Patch
M chrome/browser/chrome_browser_main_linux.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chrome_browser_main_linux.cc View 1 2 2 chunks +10 lines, -7 lines 0 comments Download
M device/media_transfer_protocol/DEPS View 1 chunk +0 lines, -1 line 0 comments Download
M device/media_transfer_protocol/media_transfer_protocol_manager.cc View 1 2 chunks +0 lines, -4 lines 0 comments Download

Messages

Total messages: 12 (0 generated)
kmadhusu
7 years, 10 months ago (2013-01-28 17:38:04 UTC) #1
Lei Zhang
Why don't we just avoid calling MediaTransferProtocolManager::Initialize() and Shutdown() instead?
7 years, 10 months ago (2013-01-28 21:38:26 UTC) #2
kmadhusu
On 2013/01/28 21:38:26, Lei Zhang wrote: > Why don't we just avoid calling MediaTransferProtocolManager::Initialize() and ...
7 years, 10 months ago (2013-01-31 01:20:16 UTC) #3
Lei Zhang
https://codereview.chromium.org/12082017/diff/6001/chrome/browser/chrome_browser_main_linux.cc File chrome/browser/chrome_browser_main_linux.cc (right): https://codereview.chromium.org/12082017/diff/6001/chrome/browser/chrome_browser_main_linux.cc#newcode143 chrome/browser/chrome_browser_main_linux.cc:143: did_pre_profile_init_ = true; You have changed the meaning of ...
7 years, 10 months ago (2013-01-31 01:33:01 UTC) #4
kmadhusu
https://codereview.chromium.org/12082017/diff/6001/chrome/browser/chrome_browser_main_linux.cc File chrome/browser/chrome_browser_main_linux.cc (right): https://codereview.chromium.org/12082017/diff/6001/chrome/browser/chrome_browser_main_linux.cc#newcode143 chrome/browser/chrome_browser_main_linux.cc:143: did_pre_profile_init_ = true; On 2013/01/31 01:33:01, Lei Zhang wrote: ...
7 years, 10 months ago (2013-01-31 02:30:40 UTC) #5
Lei Zhang
lgtm
7 years, 10 months ago (2013-01-31 02:34:34 UTC) #6
kmadhusu
gdk@: Can you do the OWNER's check for device/ changes? Thanks.
7 years, 10 months ago (2013-01-31 02:45:15 UTC) #7
miket_OOO
On 2013/01/31 02:45:15, kmadhusu wrote: > gdk@: Can you do the OWNER's check for device/ ...
7 years, 10 months ago (2013-01-31 18:05:14 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kmadhusu@chromium.org/12082017/12001
7 years, 10 months ago (2013-01-31 18:10:58 UTC) #9
commit-bot: I haz the power
Step "update" is always a major failure. Look at the try server FAQ for more ...
7 years, 10 months ago (2013-01-31 18:15:59 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kmadhusu@chromium.org/12082017/12001
7 years, 10 months ago (2013-01-31 18:45:13 UTC) #11
commit-bot: I haz the power
7 years, 10 months ago (2013-01-31 20:14:09 UTC) #12
Message was sent while issue was closed.
Change committed as 179938

Powered by Google App Engine
This is Rietveld 408576698