Include pattern and functions for RegExps over the service protocol. Remove quadratic behavior from…

runtime/observatory/lib/src/elements/code_view.dart

Index: runtime/observatory/lib/src/elements/code_view.dart
diff --git a/runtime/observatory/lib/src/elements/code_view.dart b/runtime/observatory/lib/src/elements/code_view.dart
index 4995996fa3754ab019c28dbc5c99cc36e8226c69..2fef7dcda01304e68d018ca28dbed71f391be61a 100644
--- a/runtime/observatory/lib/src/elements/code_view.dart
+++ b/runtime/observatory/lib/src/elements/code_view.dart
@@ -198,7 +198,8 @@ class CodeViewElement extends ObservatoryElement {
 
   void _fillDisassemblyDOMRow(TableRowElement tr, int rowIndex) {
     var row = disassemblyTable.rows[rowIndex];
-    for (var i = 0; i < row.values.length; i++) {
+    var n = row.values.length;

[Cutch, 2015/06/25 19:38:23]

final ?

[rmacnak, 2015/06/25 19:50:26]

Done.

+    for (var i = 0; i < n; i++) {
       var cell = tr.children[i];
       cell.title = row.values[i].toString();
       cell.text = row.values[i].toString();
@@ -226,11 +227,13 @@ class CodeViewElement extends ObservatoryElement {
     }
 
     assert(tableBody.children.length == disassemblyTable.sortedRows.length);
+
     // Fill table.
-    for (var i = 0; i < disassemblyTable.sortedRows.length; i++) {
+    var i = 0;
+    for (var tr in tableBody.children) {
       var rowIndex = disassemblyTable.sortedRows[i];
-      var tr = tableBody.children[i];
       _fillDisassemblyDOMRow(tr, rowIndex);
+      i++;
     }
   }