Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(602)

Unified Diff: content/browser/frame_host/render_frame_host_manager_unittest.cc

Issue 1208143002: Move existing kSitePerProcess checks to a policy-oracle object (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@swapped_out_cmdline_checks
Patch Set: Attempt to fix compile. Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/frame_host/render_frame_host_manager_unittest.cc
diff --git a/content/browser/frame_host/render_frame_host_manager_unittest.cc b/content/browser/frame_host/render_frame_host_manager_unittest.cc
index 46bbf975037a965f6be671b9e2af02810f59e6e9..193ca583479ec2b894cd55567cede1b7053c7818 100644
--- a/content/browser/frame_host/render_frame_host_manager_unittest.cc
+++ b/content/browser/frame_host/render_frame_host_manager_unittest.cc
@@ -18,6 +18,7 @@
#include "content/browser/site_instance_impl.h"
#include "content/browser/webui/web_ui_controller_factory_registry.h"
#include "content/common/frame_messages.h"
+#include "content/common/site_isolation_policy.h"
#include "content/common/view_messages.h"
#include "content/public/browser/notification_details.h"
#include "content/public/browser/notification_service.h"
@@ -2035,8 +2036,7 @@ TEST_F(RenderFrameHostManagerTest,
// deleted when the node is detached. Motivated by http://crbug.com/441357 and
// http://crbug.com/444955.
TEST_F(RenderFrameHostManagerTest, DetachPendingChild) {
- base::CommandLine::ForCurrentProcess()->AppendSwitch(
- switches::kSitePerProcess);
+ IsolateAllSitesForTesting(base::CommandLine::ForCurrentProcess());
const GURL kUrlA("http://www.google.com/");
const GURL kUrlB("http://webkit.org/");
@@ -2159,8 +2159,7 @@ TEST_F(RenderFrameHostManagerTest, DetachPendingChild) {
// tab navigates away without reloading. The second tab's navigation shouldn't
// mess with the first tab's content. Motivated by http://crbug.com/473714.
TEST_F(RenderFrameHostManagerTest, TwoTabsCrashOneReloadsOneLeaves) {
- base::CommandLine::ForCurrentProcess()->AppendSwitch(
- switches::kSitePerProcess);
+ IsolateAllSitesForTesting(base::CommandLine::ForCurrentProcess());
const GURL kUrl1("http://www.google.com/");
const GURL kUrl2("http://webkit.org/");

Powered by Google App Engine
This is Rietveld 408576698