chrome/browser/extensions/app_process_apitest.cc - Issue 1208143002: Move existing kSitePerProcess checks to a policy-oracle object

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/app_process_apitest.cc

Issue 1208143002: Move existing kSitePerProcess checks to a policy-oracle object (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@swapped_out_cmdline_checks

Patch Set: Attempt to fix compile. Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/chrome_site_per_process_browsertest.cc ('k') | chrome/browser/password_manager/password_manager_browsertest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/app_process_apitest.cc

diff --git a/chrome/browser/extensions/app_process_apitest.cc b/chrome/browser/extensions/app_process_apitest.cc

index 7514427e757d9008d0c9fa2cde8280f0bc36a447..95395150b7ee395e4156c09617b3d60fb6d642af 100644

--- a/chrome/browser/extensions/app_process_apitest.cc

+++ b/chrome/browser/extensions/app_process_apitest.cc

@@ -775,9 +775,7 @@ IN_PROC_BROWSER_TEST_F(AppApiTest, OpenWebPopupFromWebIframe) {

active_browser_list->get(1)->tab_strip_model()->GetActiveWebContents();

content::WaitForLoadStop(popup_contents);

- bool should_be_in_same_process =

- !base::CommandLine::ForCurrentProcess()->HasSwitch(

- switches::kSitePerProcess);

+ bool should_be_in_same_process = !content::AreAllSitesIsolatedForTesting();

content::RenderProcessHost* popup_process =

popup_contents->GetRenderProcessHost();

EXPECT_EQ(should_be_in_same_process, process == popup_process);