content/browser/web_contents/web_contents_impl_unittest.cc - Issue 1208143002: Move existing kSitePerProcess checks to a policy-oracle object

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/web_contents/web_contents_impl_unittest.cc

Issue 1208143002: Move existing kSitePerProcess checks to a policy-oracle object (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@swapped_out_cmdline_checks

Patch Set: Fix some includes Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/browser/renderer_host/render_process_host_impl.cc ('K') | « content/browser/web_contents/web_contents_impl.cc ('k') | content/common/site_isolation_policy.h » ('j') | content/content_common.gypi » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/web_contents/web_contents_impl_unittest.cc

diff --git a/content/browser/web_contents/web_contents_impl_unittest.cc b/content/browser/web_contents/web_contents_impl_unittest.cc

index d2300e9db266072b6d37bcc59931adedd5d47210..380e4f27e50160e864d78b230259be1dd9fdcea3 100644

--- a/content/browser/web_contents/web_contents_impl_unittest.cc

+++ b/content/browser/web_contents/web_contents_impl_unittest.cc

@@ -32,6 +32,7 @@

#include "content/public/common/content_switches.h"

#include "content/public/common/url_constants.h"

#include "content/public/common/url_utils.h"

+#include "content/public/test/browser_test_utils.h"

#include "content/public/test/mock_render_process_host.h"

#include "content/public/test/test_utils.h"

#include "content/test/test_content_browser_client.h"

@@ -2886,8 +2887,7 @@ TEST_F(WebContentsImplTest, StartStopEventsBalance) {

// The bug manifests itself in regular mode as well, but browser-initiated

// navigation of subframes is only possible in --site-per-process mode within

// unit tests.

- base::CommandLine::ForCurrentProcess()->AppendSwitch(

- switches::kSitePerProcess);

+ IsolateAllSitesForTesting(base::CommandLine::ForCurrentProcess());

const GURL initial_url("about:blank");

const GURL main_url("http://www.chromium.org");

const GURL foo_url("http://foo.chromium.org");