components/guest_view/renderer/iframe_guest_view_container.cc - Issue 1208143002: Move existing kSitePerProcess checks to a policy-oracle object

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/guest_view/renderer/iframe_guest_view_container.cc

Issue 1208143002: Move existing kSitePerProcess checks to a policy-oracle object (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@swapped_out_cmdline_checks

Patch Set: Fix some includes Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/guest_view/browser/guest_view_base.cc ('k') | content/browser/browser_plugin/browser_plugin_guest.cc » ('j') | content/browser/frame_host/navigation_controller_impl_browsertest.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/guest_view/renderer/iframe_guest_view_container.cc

diff --git a/components/guest_view/renderer/iframe_guest_view_container.cc b/components/guest_view/renderer/iframe_guest_view_container.cc

index f26738304cccaa89374e12406b7ac54deb76a340..36ca0b682b323bc19079b0ce08fe7c57c788410e 100644

--- a/components/guest_view/renderer/iframe_guest_view_container.cc

+++ b/components/guest_view/renderer/iframe_guest_view_container.cc

@@ -4,9 +4,8 @@

#include "components/guest_view/renderer/iframe_guest_view_container.h"

-#include "base/command_line.h"

#include "components/guest_view/common/guest_view_messages.h"

-#include "content/public/common/content_switches.h"

+#include "content/public/common/browser_plugin_guest_mode.h"

#include "content/public/renderer/render_frame.h"

namespace guest_view {

@@ -14,8 +13,7 @@ namespace guest_view {

IframeGuestViewContainer::IframeGuestViewContainer(

content::RenderFrame* render_frame)

: GuestViewContainer(render_frame) {

- CHECK(base::CommandLine::ForCurrentProcess()->HasSwitch(

- switches::kSitePerProcess));

+ CHECK(content::BrowserPluginGuestMode::UseCrossProcessFramesForGuests());

// There is no BrowserPluginDelegate to wait for.

ready_ = true;

}