content/renderer/render_frame_proxy.cc - Issue 1208143002: Move existing kSitePerProcess checks to a policy-oracle object

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/render_frame_proxy.cc

Issue 1208143002: Move existing kSitePerProcess checks to a policy-oracle object (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@swapped_out_cmdline_checks

Patch Set: Partial fixes to Nasko's comments. Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/public/common/site_isolation_policy.cc ('K') | « content/renderer/render_frame_impl_browsertest.cc ('k') | content/renderer/render_view_browsertest.cc » ('j') | extensions/renderer/dispatcher.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/renderer/render_frame_proxy.cc

diff --git a/content/renderer/render_frame_proxy.cc b/content/renderer/render_frame_proxy.cc

index 2de7dafeb38f0e1ef2296139f97fa7fd1879e17b..b0cbb4928d1fccae428c119543f3f34bed0a141f 100644

--- a/content/renderer/render_frame_proxy.cc

+++ b/content/renderer/render_frame_proxy.cc

@@ -13,7 +13,7 @@

#include "content/common/frame_replication_state.h"

#include "content/common/swapped_out_messages.h"

#include "content/common/view_messages.h"

-#include "content/public/common/content_switches.h"

+#include "content/public/common/site_isolation_policy.h"

#include "content/renderer/child_frame_compositing_helper.h"

#include "content/renderer/render_frame_impl.h"

#include "content/renderer/render_thread_impl.h"

@@ -119,8 +119,7 @@ RenderFrameProxy* RenderFrameProxy::FromWebFrame(blink::WebFrame* web_frame) {

// static

bool RenderFrameProxy::IsSwappedOutStateForbidden() {

- return base::CommandLine::ForCurrentProcess()->HasSwitch(

- switches::kSitePerProcess);

+ return SiteIsolationPolicy::AreCrossProcessFramesPossible();

}

RenderFrameProxy::RenderFrameProxy(int routing_id, int frame_routing_id)