content/browser/renderer_host/render_message_filter_browsertest.cc - Issue 1208143002: Move existing kSitePerProcess checks to a policy-oracle object

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/renderer_host/render_message_filter_browsertest.cc

Issue 1208143002: Move existing kSitePerProcess checks to a policy-oracle object (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@swapped_out_cmdline_checks

Patch Set: Partial fixes to Nasko's comments. Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/browser/loader/cross_site_resource_handler.cc ('K') | « content/browser/loader/resource_dispatcher_host_impl.cc ('k') | content/browser/renderer_host/render_process_host_impl.cc » ('j') | content/browser/site_instance_impl.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/renderer_host/render_message_filter_browsertest.cc

diff --git a/content/browser/renderer_host/render_message_filter_browsertest.cc b/content/browser/renderer_host/render_message_filter_browsertest.cc

index f6ae7ae6508875206b5f3ad5125a42a99b2e6562..39d313c66b8620c64a944f827f2953205f379c3a 100644

--- a/content/browser/renderer_host/render_message_filter_browsertest.cc

+++ b/content/browser/renderer_host/render_message_filter_browsertest.cc

@@ -12,6 +12,7 @@

#include "content/common/frame_messages.h"

#include "content/public/browser/render_process_host.h"

#include "content/public/common/content_switches.h"

+#include "content/public/common/site_isolation_policy.h"

#include "content/public/test/browser_test_utils.h"

#include "content/public/test/content_browser_test.h"

#include "content/public/test/content_browser_test_utils.h"

@@ -106,8 +107,7 @@ IN_PROC_BROWSER_TEST_F(RenderMessageFilterBrowserTest, Cookies) {

IN_PROC_BROWSER_TEST_F(RenderMessageFilterBrowserTest,

CrossSiteCookieSecurityEnforcement) {

// The code under test is only active under site isolation.

- if (!base::CommandLine::ForCurrentProcess()->HasSwitch(

- switches::kSitePerProcess)) {

+ if (!SiteIsolationPolicy::AreAllSitesIsolatedForTesting()) {

return;

}