content/browser/frame_host/render_frame_host_impl.cc - Issue 1208143002: Move existing kSitePerProcess checks to a policy-oracle object

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/frame_host/render_frame_host_impl.cc

Issue 1208143002: Move existing kSitePerProcess checks to a policy-oracle object (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@swapped_out_cmdline_checks

Patch Set: Partial fixes to Nasko's comments. Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/browser/child_process_security_policy_impl.cc ('K') | « content/browser/frame_host/navigator_impl_unittest.cc ('k') | content/browser/frame_host/render_frame_host_manager.cc » ('j') | content/browser/frame_host/render_frame_host_manager.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/frame_host/render_frame_host_impl.cc

diff --git a/content/browser/frame_host/render_frame_host_impl.cc b/content/browser/frame_host/render_frame_host_impl.cc

index e24f70a6b6902c5bae10d4b94b946ca584a12f63..c5e39104d4ae34d12f78c73daa3c418e578a4f0c 100644

--- a/content/browser/frame_host/render_frame_host_impl.cc

+++ b/content/browser/frame_host/render_frame_host_impl.cc

@@ -62,6 +62,7 @@

#include "content/public/common/content_constants.h"

#include "content/public/common/content_switches.h"

#include "content/public/common/isolated_world_ids.h"

+#include "content/public/common/site_isolation_policy.h"

#include "content/public/common/url_constants.h"

#include "content/public/common/url_utils.h"

#include "ui/accessibility/ax_tree.h"

@@ -1317,8 +1318,7 @@ void RenderFrameHostImpl::OnBeginNavigation(

}

void RenderFrameHostImpl::OnDispatchLoad() {

- CHECK(base::CommandLine::ForCurrentProcess()->HasSwitch(

- switches::kSitePerProcess));

+ CHECK(SiteIsolationPolicy::AreCrossProcessFramesPossible());

// Only frames with an out-of-process parent frame should be sending this

// message.

RenderFrameProxyHost* proxy =