Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(44)

Issue 120813004: Drop |data_offset| in cdm::InputBuffer. (Closed)

Created:
6 years, 11 months ago by xhwang
Modified:
6 years, 4 months ago
CC:
cdm-api-reviews_chromium.org, feature-media-reviews_chromium.org
Visibility:
Public.

Description

Drop |data_offset| in cdm::InputBuffer. BUG=298569 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=288101

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+41 lines, -9 lines) Patch
M content_decryption_module.h View 1 8 chunks +41 lines, -9 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
xhwang
ddorwin: PTAL rkuroiwa: FYI
6 years, 11 months ago (2014-01-08 23:38:17 UTC) #1
ddorwin
Can we just rename the data_offset member "reserved" to prevent use and simplify things? We'd ...
6 years, 11 months ago (2014-01-08 23:42:37 UTC) #2
xhwang
On 2014/01/08 23:42:37, ddorwin wrote: > Can we just rename the data_offset member "reserved" to ...
6 years, 11 months ago (2014-01-09 00:01:36 UTC) #3
ddorwin
Can you rebase this and add it to CDM_6 before that stabilizes?
6 years, 4 months ago (2014-08-07 01:18:03 UTC) #4
xhwang
Rebased. PTAL
6 years, 4 months ago (2014-08-07 17:45:36 UTC) #5
ddorwin
lgtm Thanks.
6 years, 4 months ago (2014-08-07 17:56:28 UTC) #6
jrummell
lgtm
6 years, 4 months ago (2014-08-07 18:14:04 UTC) #7
xhwang
The CQ bit was checked by xhwang@chromium.org
6 years, 4 months ago (2014-08-07 18:39:50 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/xhwang@chromium.org/120813004/80001
6 years, 4 months ago (2014-08-07 18:40:54 UTC) #9
commit-bot: I haz the power
6 years, 4 months ago (2014-08-07 18:41:37 UTC) #10
Message was sent while issue was closed.
Change committed as 288101

Powered by Google App Engine
This is Rietveld 408576698