about:omnibox - add "in keyword mode" checkbox

chrome/browser/ui/webui/omnibox/omnibox_ui_handler.h

Index: chrome/browser/ui/webui/omnibox/omnibox_ui_handler.h
diff --git a/chrome/browser/ui/webui/omnibox/omnibox_ui_handler.h b/chrome/browser/ui/webui/omnibox/omnibox_ui_handler.h
index e040493ddc114ed2db8f105bce52858687960686..8723f26d03584ddeb3172755ef1d4e6d930d7918 100644
--- a/chrome/browser/ui/webui/omnibox/omnibox_ui_handler.h
+++ b/chrome/browser/ui/webui/omnibox/omnibox_ui_handler.h
@@ -49,11 +49,12 @@ class OmniboxUIHandler : public AutocompleteControllerDelegate,
  private:
   // Gets called from the javascript when a user enters text into the
   // chrome://omnibox/ text box and clicks submit or hits enter.
-  // |three_element_input_string| is expected to be a three-element list:
+  // |four_element_input_string| is expected to be a four-element list:

[Bart N., 2013/01/25 21:52:04]

Honestly, I've never seen this style (naming vars to include number of elements)
as it's too verbose and error prone (as you can see in this very example, see my
comment below). I think comment is sufficient that we expect 4 elements.

How about: "input_string"?

[Mark P, 2013/01/25 22:24:58]

I always felt silly updating this code from two to three to four.  It never
occurred to me to rename the variable!  Crazy.  Now done.

   // - first element: input string.
-  // - second element: boolean indicating whether we should set
+  // - second element: the cursor position.
+  // - third element: boolean indicating whether we should set
   //   prevent_inline_autocomplete or not.
-  // - third element: the cursor position.
+  // - forth element: boolean indicating whether we should set prefer_keyword
   void StartOmniboxQuery(const base::ListValue* two_element_input_string);

[Bart N., 2013/01/25 21:52:04]

s/two/four

[Mark P, 2013/01/25 22:24:58]

Done.

 
   // Helper function for OnResultChanged().