Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(20)

Issue 1208073002: [MIPS] Add support for direct-to-nacl in Clang (Closed)

Created:
5 years, 6 months ago by petarj
Modified:
5 years, 5 months ago
Reviewers:
Derek Schuff
CC:
native-client-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/native_client/pnacl-clang.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

[MIPS] Add support for direct-to-nacl in Clang Cherry-picked r241678 from upstream, modified it to the current PNaCl-Clang tree, and added an extra flag "-direct-to-nacl" that is not present upstream. Original commit message: For Mips direct-to-nacl, the goal is to be close to le32 front-end and use Mips32EL backend. This patch defines new NaClMips32ELTargetInfo and modifies it slightly to be close to le32. It also adds necessary parts, inline with ARM and X86. BUG= https://code.google.com/p/nativeclient/issues/detail?id=4205 R=dschuff@chromium.org Committed: 239048208dd9a33e670cad064b47b92a9f4335ec

Patch Set 1 #

Patch Set 2 : Updated change. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+88 lines, -2 lines) Patch
M lib/Basic/Targets.cpp View 2 chunks +14 lines, -1 line 0 comments Download
M lib/CodeGen/TargetInfo.cpp View 1 1 chunk +2 lines, -0 lines 0 comments Download
M lib/Driver/ToolChains.h View 1 chunk +3 lines, -1 line 0 comments Download
M lib/Driver/ToolChains.cpp View 1 2 chunks +11 lines, -0 lines 0 comments Download
M lib/Driver/Tools.cpp View 1 4 chunks +23 lines, -0 lines 0 comments Download
M test/Driver/nacl-direct.c View 1 2 chunks +35 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (1 generated)
petarj
PTAL.
5 years, 6 months ago (2015-06-25 15:48:31 UTC) #2
Derek Schuff
On 2015/06/25 15:48:31, petarj wrote: > PTAL. looks mostly ok. I'm not a big fan ...
5 years, 6 months ago (2015-06-25 17:05:07 UTC) #3
petarj
On 2015/06/25 17:05:07, Derek Schuff wrote: > On 2015/06/25 15:48:31, petarj wrote: > > PTAL. ...
5 years, 6 months ago (2015-06-25 17:57:36 UTC) #4
Derek Schuff
On 2015/06/25 17:57:36, petarj wrote: > On 2015/06/25 17:05:07, Derek Schuff wrote: > > On ...
5 years, 6 months ago (2015-06-25 18:18:16 UTC) #5
Derek Schuff
LGTM if this can now be the same as the upstream change (with the extra ...
5 years, 5 months ago (2015-07-22 00:38:10 UTC) #6
petarj
The change has been updated.
5 years, 5 months ago (2015-07-24 18:19:11 UTC) #7
petarj
5 years, 5 months ago (2015-07-24 18:44:18 UTC) #8
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
239048208dd9a33e670cad064b47b92a9f4335ec (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698