Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(189)

Issue 1208053008: Teach Stocks how to load data when run from a package (Closed)

Created:
5 years, 5 months ago by abarth-chromium
Modified:
5 years, 5 months ago
Reviewers:
eseidel1, eseidel
CC:
gregsimon, jackson_old, mojo-reviews_chromium.org, qsr+mojo_chromium.org
Base URL:
git@github.com:domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Teach Stocks how to load data when run from a package When run with a root bundle, the Stocks app now fetches its data from the Internet. R=eseidel@chromium.org, eseidel@google.com Committed: https://chromium.googlesource.com/external/mojo/+/6a78bbcc03c163bc877eeb2c2085636a6182e22f

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -1 line) Patch
M sky/sdk/example/stocks/lib/stock_data.dart View 3 chunks +8 lines, -1 line 0 comments Download

Messages

Total messages: 4 (1 generated)
abarth-chromium
5 years, 5 months ago (2015-07-07 21:06:23 UTC) #1
eseidel
lgtm
5 years, 5 months ago (2015-07-07 21:07:02 UTC) #3
abarth-chromium
5 years, 5 months ago (2015-07-07 21:15:39 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
6a78bbcc03c163bc877eeb2c2085636a6182e22f (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698