Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(73)

Issue 1208053007: Update the GN style guide on target naming. (Closed)

Created:
5 years, 5 months ago by brettw
Modified:
5 years, 5 months ago
Reviewers:
Dirk Pranke
CC:
chromium-reviews, tfarina
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Update the GN style guide on target naming. This makes it clear that executable names should be unique. TBR=dpranke Committed: https://crrev.com/b4729ae5177c9b4fe72c6fe9f147990829d6bbef Cr-Commit-Position: refs/heads/master@{#337635}

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -16 lines) Patch
M tools/gn/docs/style_guide.md View 1 chunk +16 lines, -16 lines 1 comment Download

Messages

Total messages: 8 (2 generated)
brettw
5 years, 5 months ago (2015-07-07 17:30:23 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1208053007/1
5 years, 5 months ago (2015-07-07 17:31:35 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 5 months ago (2015-07-07 17:41:10 UTC) #5
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/b4729ae5177c9b4fe72c6fe9f147990829d6bbef Cr-Commit-Position: refs/heads/master@{#337635}
5 years, 5 months ago (2015-07-07 17:42:11 UTC) #6
Dirk Pranke
lgtm. https://codereview.chromium.org/1208053007/diff/1/tools/gn/docs/style_guide.md File tools/gn/docs/style_guide.md (right): https://codereview.chromium.org/1208053007/diff/1/tools/gn/docs/style_guide.md#newcode27 tools/gn/docs/style_guide.md:27: Naming advice nit: did you mean for this ...
5 years, 5 months ago (2015-07-07 18:56:49 UTC) #7
brettw
5 years, 5 months ago (2015-07-07 19:06:19 UTC) #8
Message was sent while issue was closed.
On 2015/07/07 18:56:49, Dirk Pranke wrote:
>
https://codereview.chromium.org/1208053007/diff/1/tools/gn/docs/style_guide.m...
> tools/gn/docs/style_guide.md:27: Naming advice
> nit: did you mean for this to be a subheading, or just a new paragraph (it's
the
> latter now)?

I think the formatting turned out the way I expected.

Powered by Google App Engine
This is Rietveld 408576698