Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(350)

Issue 1207973002: Fixes for views_unittests on Mac after InputMethodBridge removal (DO NOT COMMIT) (Closed)

Created:
5 years, 6 months ago by tapted
Modified:
5 years, 5 months ago
Reviewers:
Shu Chen
CC:
chromium-reviews, yusukes+watch_chromium.org, tfarina, shuchen+watch_chromium.org, penghuang+watch_chromium.org, nona+watch_chromium.org, James Su, chrome-apps-syd-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@20150625-IMERefactorMac-UPSTREAM
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fixes for views_unittests on Mac after InputMethodBridge removal (DO NOT COMMIT) Patch on top of https://codereview.chromium.org/1177503003 Changes for the new recipe-based trybots means views_unittests is no longer compiled on the default trybots. However, it looks like it's still build in the waterfall :/ (e.g. builds on http://build.chromium.org/p/chromium.mac/builders/Mac%20Builder ) BUG=

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+49 lines, -21 lines) Patch
M ui/views/cocoa/bridged_native_widget.h View 3 chunks +12 lines, -6 lines 0 comments Download
M ui/views/cocoa/bridged_native_widget.mm View 2 chunks +12 lines, -3 lines 1 comment Download
M ui/views/cocoa/bridged_native_widget_unittest.mm View 2 chunks +3 lines, -8 lines 0 comments Download
M ui/views/controls/textfield/textfield_unittest.cc View 2 chunks +2 lines, -4 lines 0 comments Download
M ui/views/test/widget_test.h View 2 chunks +7 lines, -0 lines 0 comments Download
M ui/views/test/widget_test_aura.cc View 1 chunk +6 lines, -0 lines 0 comments Download
M ui/views/test/widget_test_mac.mm View 2 chunks +7 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (1 generated)
tapted
Hi Shu, This is not for landing, but I think these changes will be needed ...
5 years, 6 months ago (2015-06-25 11:54:15 UTC) #2
Shu Chen
5 years, 6 months ago (2015-06-26 03:58:13 UTC) #3
Thanks for catching the issue!

I've merged this to cl https://codereview.chromium.org/1177503003.

Powered by Google App Engine
This is Rietveld 408576698