Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(149)

Unified Diff: runtime/vm/snapshot_test.cc

Issue 12079117: Revert changes 17962-3 which break Dartium Debug build. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 7 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/snapshot.cc ('k') | runtime/vm/snapshot_test.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/snapshot_test.cc
diff --git a/runtime/vm/snapshot_test.cc b/runtime/vm/snapshot_test.cc
index 80e0ce67de6ca952d201f5a4f05ecb66779c2cf6..3628e9bc15bfb47307d4c473931683633a026b06 100644
--- a/runtime/vm/snapshot_test.cc
+++ b/runtime/vm/snapshot_test.cc
@@ -929,17 +929,15 @@ UNIT_TEST_CASE(FullSnapshot) {
{
TestIsolateScope __test_isolate__;
- Isolate* isolate = Isolate::Current();
- StackZone zone(isolate);
- HandleScope scope(isolate);
-
// Create a test library and Load up a test script in it.
TestCase::LoadTestScript(kScriptChars, NULL);
- EXPECT_STREQ("", CheckIsolateState(isolate));
timer1.Stop();
OS::PrintErr("Without Snapshot: %"Pd64"us\n", timer1.TotalElapsedTime());
// Write snapshot with object content.
+ Isolate* isolate = Isolate::Current();
+ StackZone zone(isolate);
+ HandleScope scope(isolate);
FullSnapshotWriter writer(&buffer, &malloc_allocator);
writer.WriteFullSnapshot();
}
@@ -989,7 +987,7 @@ UNIT_TEST_CASE(FullSnapshot1) {
// Create a test library and Load up a test script in it.
Dart_Handle lib = TestCase::LoadTestScript(kScriptChars, NULL);
- EXPECT_STREQ("", CheckIsolateState(isolate));
+ ClassFinalizer::FinalizePendingClasses();
timer1.Stop();
OS::PrintErr("Without Snapshot: %"Pd64"us\n", timer1.TotalElapsedTime());
@@ -1106,7 +1104,6 @@ UNIT_TEST_CASE(ScriptSnapshot) {
EXPECT_VALID(Dart_LibraryImportLibrary(TestCase::lib(),
import_lib,
Dart_Null()));
- EXPECT_STREQ("", CheckIsolateState(Isolate::Current()));
// Get list of library URLs loaded and save the count.
Dart_Handle libs = Dart_GetLibraryURLs();
« no previous file with comments | « runtime/vm/snapshot.cc ('k') | runtime/vm/snapshot_test.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698