Make a bunch of stuff in pub synchronous.

utils/pub/command_lish.dart

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 library command_lish;
 
 import 'dart:async';
 import 'dart:io';
 import 'dart:json';
 import 'dart:uri';
@@ skipping 98 matching lines @@
   /// The basenames of directories that are automatically excluded from
   /// archives.
   final _BLACKLISTED_DIRECTORIES = const ['packages'];
 
   /// Returns a list of files that should be included in the published package.
   /// If this is a Git repository, this will respect .gitignore; otherwise, it
   /// will return all non-hidden files.
   Future<List<String>> get _filesToPublish {
     var rootDir = entrypoint.root.dir;
 
-    return Future.wait([
-      dirExists(join(rootDir, '.git')),
-      git.isInstalled
-    ]).then((results) {
-      if (results[0] && results[1]) {
+    return git.isInstalled.then((results) {

[nweiz, 2013/02/01 02:05:55]

"results" -> "gitInstalled"

It's worrisome that this didn't show up in our tests.

[Bob Nystrom, 2013/02/01 23:17:21]

It did. :( pub_lish_test is flaky so you don't see it when it fails. :(

I'll get it passing locally and then try to get that status fixed soon.

+      if (dirExists(join(rootDir, '.git')) && gitInstalled) {
         // List all files that aren't gitignored, including those not checked
         // in to Git.
         return git.run(["ls-files", "--cached", "--others",
                         "--exclude-standard"]);
       }
 
       return listDir(rootDir, recursive: true).then((entries) {
         return Future.wait(entries.map((entry) {
-          return fileExists(entry).then((isFile) {
             // Skip directories.
-            if (!isFile) return null;
+          if (!fileExists(entry)) return null;
 
-            // TODO(rnystrom): Making these relative will break archive
-            // creation if the cwd is ever *not* the package root directory.
-            // Should instead only make these relative right before generating
-            // the tree display (which is what really needs them to be).
-            // Make it relative to the package root.
-            return relativeTo(entry, rootDir);
-          });
+          // TODO(rnystrom): Making these relative will break archive
+          // creation if the cwd is ever *not* the package root directory.
+          // Should instead only make these relative right before generating
+          // the tree display (which is what really needs them to be).
+          // Make it relative to the package root.
+          return relativeTo(entry, rootDir);
         }));
       });
     }).then((files) => files.where((file) {
       if (file == null || _BLACKLISTED_FILES.contains(basename(file))) {
         return false;
       }
 
       return !splitPath(file).any(_BLACKLISTED_DIRECTORIES.contains);
     }).toList());
   }
@@ skipping 24 matching lines @@
         var s = warnings.length == 1 ? '' : 's';
         message = "Package has ${warnings.length} warning$s. Upload anyway";
       }
 
       return confirm(message).then((confirmed) {
         if (!confirmed) throw "Package upload canceled.";
       });
     });
   }
 }