chrome/browser/ui/webui/ntp/new_tab_page_handler.cc - Issue 12079097: Introduce PrefRegistrySyncable, simplifying PrefServiceSyncable.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/webui/ntp/new_tab_page_handler.cc

Issue 12079097: Introduce PrefRegistrySyncable, simplifying PrefServiceSyncable. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Merge to head again; base::File changes conflicted. Created 7 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/webui/ntp/new_tab_page_handler.cc

diff --git a/chrome/browser/ui/webui/ntp/new_tab_page_handler.cc b/chrome/browser/ui/webui/ntp/new_tab_page_handler.cc

index 8416cfafce3f1f36a5a0bdaf84a68d47568e14ee..70b72a8b5dccbd72542fc280c3e198ca634067ec 100644

--- a/chrome/browser/ui/webui/ntp/new_tab_page_handler.cc

+++ b/chrome/browser/ui/webui/ntp/new_tab_page_handler.cc

@@ -9,6 +9,7 @@

#include "base/memory/scoped_ptr.h"

#include "base/metrics/histogram.h"

#include "chrome/browser/extensions/app_launcher.h"

+#include "chrome/browser/prefs/pref_registry_syncable.h"

#include "chrome/browser/prefs/pref_service.h"

#include "chrome/browser/profiles/profile.h"

#include "chrome/browser/sync/profile_sync_service.h"

@@ -183,10 +184,10 @@ void NewTabPageHandler::GotIsAppLauncherEnabled(bool is_enabled) {

}

// static

-void NewTabPageHandler::RegisterUserPrefs(PrefServiceSyncable* prefs) {

+void NewTabPageHandler::RegisterUserPrefs(PrefRegistrySyncable* registry) {

// TODO(estade): should be syncable.

- prefs->RegisterIntegerPref(prefs::kNtpShownPage, APPS_PAGE_ID,

- PrefServiceSyncable::UNSYNCABLE_PREF);

+ registry->RegisterIntegerPref(prefs::kNtpShownPage, APPS_PAGE_ID,

+ PrefRegistrySyncable::UNSYNCABLE_PREF);

}

// static