Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(77)

Unified Diff: chrome/browser/prefs/pref_service_unittest.cc

Issue 12079097: Introduce PrefRegistrySyncable, simplifying PrefServiceSyncable. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Merge to head again; base::File changes conflicted. Created 7 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/prefs/pref_service_unittest.cc
diff --git a/chrome/browser/prefs/pref_service_unittest.cc b/chrome/browser/prefs/pref_service_unittest.cc
index 82e3fe041627a1cb57d33d46305ad36c0b17042c..1a5ab78d29b06f0567ef29c5bd41446ff565dc02 100644
--- a/chrome/browser/prefs/pref_service_unittest.cc
+++ b/chrome/browser/prefs/pref_service_unittest.cc
@@ -20,6 +20,7 @@
#include "chrome/browser/prefs/command_line_pref_store.h"
#include "chrome/browser/prefs/mock_pref_change_callback.h"
#include "chrome/browser/prefs/pref_registry_simple.h"
+#include "chrome/browser/prefs/pref_registry_syncable.h"
#include "chrome/browser/prefs/pref_service_mock_builder.h"
#include "chrome/browser/prefs/pref_value_store.h"
#include "chrome/browser/prefs/scoped_user_pref_update.h"
@@ -322,25 +323,26 @@ TEST_F(PrefServiceUserFilePrefsTest, PreserveEmptyValue) {
PrefServiceMockBuilder builder;
builder.WithUserFilePrefs(pref_file, message_loop_.message_loop_proxy());
- scoped_ptr<PrefServiceSyncable> prefs(builder.CreateSyncable());
+ scoped_refptr<PrefRegistrySyncable> registry(new PrefRegistrySyncable);
+ scoped_ptr<PrefServiceSyncable> prefs(builder.CreateSyncable(registry));
// Register testing prefs.
- prefs->RegisterListPref("list",
- PrefServiceSyncable::UNSYNCABLE_PREF);
- prefs->RegisterDictionaryPref("dict",
- PrefServiceSyncable::UNSYNCABLE_PREF);
+ registry->RegisterListPref("list",
+ PrefRegistrySyncable::UNSYNCABLE_PREF);
+ registry->RegisterDictionaryPref("dict",
+ PrefRegistrySyncable::UNSYNCABLE_PREF);
base::ListValue* non_empty_list = new base::ListValue;
non_empty_list->Append(base::Value::CreateStringValue("test"));
- prefs->RegisterListPref("list_needs_empty_value",
- non_empty_list,
- PrefServiceSyncable::UNSYNCABLE_PREF);
+ registry->RegisterListPref("list_needs_empty_value",
+ non_empty_list,
+ PrefRegistrySyncable::UNSYNCABLE_PREF);
base::DictionaryValue* non_empty_dict = new base::DictionaryValue;
non_empty_dict->SetString("dummy", "whatever");
- prefs->RegisterDictionaryPref("dict_needs_empty_value",
- non_empty_dict,
- PrefServiceSyncable::UNSYNCABLE_PREF);
+ registry->RegisterDictionaryPref("dict_needs_empty_value",
+ non_empty_dict,
+ PrefRegistrySyncable::UNSYNCABLE_PREF);
// Set all testing prefs to empty.
ClearListValue(prefs.get(), "list");
« no previous file with comments | « chrome/browser/prefs/pref_service_syncable_builder.cc ('k') | chrome/browser/prefs/proxy_policy_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698