Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(53)

Unified Diff: chrome/browser/prefs/pref_service_syncable_builder.cc

Issue 12079097: Introduce PrefRegistrySyncable, simplifying PrefServiceSyncable. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Merge to head again; base::File changes conflicted. Created 7 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/prefs/pref_service_syncable_builder.h ('k') | chrome/browser/prefs/pref_service_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/prefs/pref_service_syncable_builder.cc
diff --git a/chrome/browser/prefs/pref_service_syncable_builder.cc b/chrome/browser/prefs/pref_service_syncable_builder.cc
index 8a157dd310bda24b78828dfcd55b21c060a527c2..4a51a86ba6e4ef7ba38283ba705b63071d2dbea6 100644
--- a/chrome/browser/prefs/pref_service_syncable_builder.cc
+++ b/chrome/browser/prefs/pref_service_syncable_builder.cc
@@ -9,7 +9,7 @@
#include "chrome/browser/policy/policy_service.h"
#include "chrome/browser/prefs/command_line_pref_store.h"
#include "chrome/browser/prefs/pref_notifier_impl.h"
-#include "chrome/browser/prefs/pref_registry_simple.h"
+#include "chrome/browser/prefs/pref_registry_syncable.h"
#include "chrome/browser/prefs/pref_service_syncable.h"
#include "chrome/browser/prefs/pref_value_store.h"
@@ -41,9 +41,8 @@ PrefServiceSyncableBuilder::WithCommandLine(CommandLine* command_line) {
return *this;
}
-PrefServiceSyncable* PrefServiceSyncableBuilder::CreateSyncable() {
- // TODO(joi): Switch to accepting a PrefRegistrySyncable parameter.
- scoped_refptr<PrefRegistry> pref_registry = new PrefRegistrySimple();
+PrefServiceSyncable* PrefServiceSyncableBuilder::CreateSyncable(
+ PrefRegistrySyncable* pref_registry) {
PrefNotifierImpl* pref_notifier = new PrefNotifierImpl();
PrefServiceSyncable* pref_service = new PrefServiceSyncable(
pref_notifier,
@@ -56,7 +55,7 @@ PrefServiceSyncable* PrefServiceSyncableBuilder::CreateSyncable() {
pref_registry->defaults(),
pref_notifier),
user_prefs_.get(),
- pref_registry.get(),
+ pref_registry,
read_error_callback_,
async_);
ResetDefaultState();
« no previous file with comments | « chrome/browser/prefs/pref_service_syncable_builder.h ('k') | chrome/browser/prefs/pref_service_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698