chrome/browser/extensions/api/commands/command_service.cc - Issue 12079097: Introduce PrefRegistrySyncable, simplifying PrefServiceSyncable.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/commands/command_service.cc

Issue 12079097: Introduce PrefRegistrySyncable, simplifying PrefServiceSyncable. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Merge to head again; base::File changes conflicted. Created 7 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/extensions/api/commands/command_service.cc

diff --git a/chrome/browser/extensions/api/commands/command_service.cc b/chrome/browser/extensions/api/commands/command_service.cc

index 91fae35244e2d2327c04ac0755daadc8503ebfb6..84b40e454dbae635f287d700f89b1db18a7b4d1b 100644

--- a/chrome/browser/extensions/api/commands/command_service.cc

+++ b/chrome/browser/extensions/api/commands/command_service.cc

@@ -12,6 +12,7 @@

#include "chrome/browser/extensions/extension_keybinding_registry.h"

#include "chrome/browser/extensions/extension_service.h"

#include "chrome/browser/extensions/extension_system.h"

+#include "chrome/browser/prefs/pref_registry_syncable.h"

#include "chrome/browser/prefs/scoped_user_pref_update.h"

#include "chrome/browser/profiles/profile.h"

#include "chrome/common/chrome_notification_types.h"

@@ -39,9 +40,9 @@ std::string GetPlatformKeybindingKeyForAccelerator(

namespace extensions {

// static

-void CommandService::RegisterUserPrefs(PrefServiceSyncable* user_prefs) {

- user_prefs->RegisterDictionaryPref(prefs::kExtensionCommands,

- PrefServiceSyncable::SYNCABLE_PREF);

+void CommandService::RegisterUserPrefs(PrefRegistrySyncable* registry) {

+ registry->RegisterDictionaryPref(prefs::kExtensionCommands,

+ PrefRegistrySyncable::SYNCABLE_PREF);

}

CommandService::CommandService(Profile* profile)