Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5525)

Unified Diff: chrome/browser/chromeos/login/oauth2_login_manager.cc

Issue 12079097: Introduce PrefRegistrySyncable, simplifying PrefServiceSyncable. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Merge to head again; base::File changes conflicted. Created 7 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/chromeos/language_preferences.cc ('k') | chrome/browser/chromeos/preferences.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/chromeos/login/oauth2_login_manager.cc
diff --git a/chrome/browser/chromeos/login/oauth2_login_manager.cc b/chrome/browser/chromeos/login/oauth2_login_manager.cc
index 983d92ed9ad026adf72c4501b5c8c232f78db02e..6d67d7c4d7813ea1904bbf0409692d8f84cff41e 100644
--- a/chrome/browser/chromeos/login/oauth2_login_manager.cc
+++ b/chrome/browser/chromeos/login/oauth2_login_manager.cc
@@ -9,6 +9,7 @@
#include "chrome/browser/browser_process.h"
#include "chrome/browser/chromeos/login/user_manager.h"
#include "chrome/browser/policy/browser_policy_connector.h"
+#include "chrome/browser/prefs/pref_registry_syncable.h"
#include "chrome/browser/prefs/pref_service.h"
#include "chrome/browser/profiles/profile.h"
#include "chrome/browser/signin/token_service.h"
@@ -91,17 +92,20 @@ TokenService* OAuth2LoginManager::SetupTokenService() {
}
void OAuth2LoginManager::RemoveLegacyTokens() {
- PrefServiceSyncable* prefs = user_profile_->GetPrefs();
- prefs->RegisterStringPref(prefs::kOAuth1Token,
- "",
- PrefServiceSyncable::UNSYNCABLE_PREF);
- prefs->RegisterStringPref(prefs::kOAuth1Secret,
- "",
- PrefServiceSyncable::UNSYNCABLE_PREF);
+ PrefService* prefs = user_profile_->GetPrefs();
+ // TODO(joi): Registration should only be done up front.
+ scoped_refptr<PrefRegistrySyncable> registry(
+ static_cast<PrefRegistrySyncable*>(prefs->DeprecatedGetPrefRegistry()));
+ registry->RegisterStringPref(prefs::kOAuth1Token,
+ "",
+ PrefRegistrySyncable::UNSYNCABLE_PREF);
+ registry->RegisterStringPref(prefs::kOAuth1Secret,
+ "",
+ PrefRegistrySyncable::UNSYNCABLE_PREF);
prefs->ClearPref(prefs::kOAuth1Token);
prefs->ClearPref(prefs::kOAuth1Secret);
- prefs->UnregisterPreference(prefs::kOAuth1Token);
- prefs->UnregisterPreference(prefs::kOAuth1Secret);
+ registry->DeprecatedUnregisterPreference(prefs::kOAuth1Token);
+ registry->DeprecatedUnregisterPreference(prefs::kOAuth1Secret);
}
void OAuth2LoginManager::StoreOAuth2Tokens(
« no previous file with comments | « chrome/browser/chromeos/language_preferences.cc ('k') | chrome/browser/chromeos/preferences.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698