Introduce PrefRegistrySyncable, simplifying PrefServiceSyncable.

chrome/test/base/testing_pref_service.cc

Index: chrome/test/base/testing_pref_service.cc
diff --git a/chrome/test/base/testing_pref_service.cc b/chrome/test/base/testing_pref_service.cc
index a6801dda88d8e6963b2fa335bd67270bc8593881..b7cd5a67680aa7ed2e3e68f6de47f1377ba4bf3c 100644
--- a/chrome/test/base/testing_pref_service.cc
+++ b/chrome/test/base/testing_pref_service.cc
@@ -10,6 +10,7 @@
 #include "chrome/browser/prefs/browser_prefs.h"
 #include "chrome/browser/prefs/pref_notifier_impl.h"
 #include "chrome/browser/prefs/pref_registry_simple.h"
+#include "chrome/browser/prefs/pref_registry_syncable.h"
 #include "chrome/browser/prefs/pref_value_store.h"
 #include "chrome/test/base/testing_browser_process.h"
 #include "testing/gtest/include/gtest/gtest.h"
@@ -64,7 +65,7 @@ TestingPrefServiceBase<PrefServiceSyncable>::TestingPrefServiceBase(
                               pref_registry->defaults(),
                               pref_notifier),
                           user_prefs,
-                          pref_registry,
+                          static_cast<PrefRegistrySyncable*>(pref_registry),
                           base::Bind(&HandleReadError),
                           false),
       managed_prefs_(managed_prefs),
@@ -88,24 +89,28 @@ PrefRegistrySimple* TestingPrefServiceSimple::registry() {
   return static_cast<PrefRegistrySimple*>(DeprecatedGetPrefRegistry());
 }
 
-// TODO(joi): Switch to PrefRegistrySyncable once available.
 TestingPrefServiceSyncable::TestingPrefServiceSyncable()
     : TestingPrefServiceBase<PrefServiceSyncable>(
         new TestingPrefStore(),
         new TestingPrefStore(),
         new TestingPrefStore(),
-        new PrefRegistrySimple(),
+        new PrefRegistrySyncable(),
         new PrefNotifierImpl()) {
 }
 
 TestingPrefServiceSyncable::~TestingPrefServiceSyncable() {
 }
 
+PrefRegistrySyncable* TestingPrefServiceSyncable::registry() {
+  return static_cast<PrefRegistrySyncable*>(DeprecatedGetPrefRegistry());
+}
+
 ScopedTestingLocalState::ScopedTestingLocalState(
     TestingBrowserProcess* browser_process)
     : browser_process_(browser_process) {
-  chrome::RegisterLocalState(static_cast<PrefRegistrySimple*>(
-      local_state_.DeprecatedGetPrefRegistry()), &local_state_);
+  chrome::RegisterLocalState(&local_state_,
+                             static_cast<PrefRegistrySimple*>(
+                                 local_state_.DeprecatedGetPrefRegistry()));

[Mattias Nissler (ping if slow), 2013/02/06 17:53:33]

local_state_ is a TestingPrefServiceSimple - local_state_.registry() should just
work?

[Jói, 2013/02/07 14:52:32]

Done.

   EXPECT_FALSE(browser_process->local_state());
   browser_process->SetLocalState(&local_state_);
 }