Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1595)

Unified Diff: chrome/browser/web_resource/notification_promo.cc

Issue 12079097: Introduce PrefRegistrySyncable, simplifying PrefServiceSyncable. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Add to PrefRegistrySyncable and PrefServiceSyncable to let sync know of pre-registered prefs. Created 7 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/web_resource/notification_promo.cc
diff --git a/chrome/browser/web_resource/notification_promo.cc b/chrome/browser/web_resource/notification_promo.cc
index 71f9d0d22bc76747628242556f237131caae28c9..8540a0bfb156dc9e8ee196ebe505966cfe2dbcbd 100644
--- a/chrome/browser/web_resource/notification_promo.cc
+++ b/chrome/browser/web_resource/notification_promo.cc
@@ -17,8 +17,8 @@
#include "base/values.h"
#include "chrome/browser/browser_process.h"
#include "chrome/browser/prefs/pref_registry_simple.h"
+#include "chrome/browser/prefs/pref_registry_syncable.h"
#include "chrome/browser/prefs/pref_service.h"
-#include "chrome/browser/prefs/pref_service_syncable.h"
#include "chrome/browser/web_resource/promo_resource_service.h"
#include "chrome/common/chrome_version_info.h"
#include "chrome/common/pref_names.h"
@@ -315,11 +315,12 @@ void NotificationPromo::RegisterPrefs(PrefRegistrySimple* registry) {
}
// static
-void NotificationPromo::RegisterUserPrefs(PrefServiceSyncable* prefs) {
+void NotificationPromo::RegisterUserPrefs(PrefService* prefs,
+ PrefRegistrySyncable* registry) {
// TODO(dbeam): Remove in M28 when we're reasonably sure all prefs are gone.
// http://crbug.com/168887
- prefs->RegisterDictionaryPref(kPrefPromoObject,
- PrefServiceSyncable::UNSYNCABLE_PREF);
+ registry->RegisterDictionaryPref(kPrefPromoObject,
+ PrefRegistrySyncable::UNSYNCABLE_PREF);
Mattias Nissler (ping if slow) 2013/02/06 17:53:33 TODO remove prefs parameter, this should be part o
Jói 2013/02/07 14:52:32 Done.
prefs->ClearPref(kPrefPromoObject);
}

Powered by Google App Engine
This is Rietveld 408576698