Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(491)

Unified Diff: chrome/browser/ui/webui/sync_promo/sync_promo_ui.cc

Issue 12079097: Introduce PrefRegistrySyncable, simplifying PrefServiceSyncable. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Add to PrefRegistrySyncable and PrefServiceSyncable to let sync know of pre-registered prefs. Created 7 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/webui/sync_promo/sync_promo_ui.cc
diff --git a/chrome/browser/ui/webui/sync_promo/sync_promo_ui.cc b/chrome/browser/ui/webui/sync_promo/sync_promo_ui.cc
index dd8a79ec53d48a23d43dc0d21dde074c1a3c8ca3..380e4d39d43a4a8b5d5ea8d3ba359a2286223cfe 100644
--- a/chrome/browser/ui/webui/sync_promo/sync_promo_ui.cc
+++ b/chrome/browser/ui/webui/sync_promo/sync_promo_ui.cc
@@ -12,6 +12,7 @@
#include "chrome/browser/browser_process.h"
#include "chrome/browser/first_run/first_run.h"
#include "chrome/browser/google/google_util.h"
+#include "chrome/browser/prefs/pref_registry_syncable.h"
#include "chrome/browser/prefs/pref_service.h"
#include "chrome/browser/profiles/profile.h"
#include "chrome/browser/profiles/profile_info_cache.h"
@@ -135,15 +136,15 @@ bool SyncPromoUI::ShouldShowSyncPromo(Profile* profile) {
}
// static
-void SyncPromoUI::RegisterUserPrefs(PrefServiceSyncable* prefs) {
- prefs->RegisterIntegerPref(prefs::kSyncPromoStartupCount, 0,
- PrefServiceSyncable::UNSYNCABLE_PREF);
- prefs->RegisterBooleanPref(prefs::kSyncPromoUserSkipped, false,
- PrefServiceSyncable::UNSYNCABLE_PREF);
- prefs->RegisterBooleanPref(prefs::kSyncPromoShowOnFirstRunAllowed, true,
- PrefServiceSyncable::UNSYNCABLE_PREF);
-
- SyncPromoHandler::RegisterUserPrefs(prefs);
+void SyncPromoUI::RegisterUserPrefs(PrefRegistrySyncable* registry) {
+ registry->RegisterIntegerPref(prefs::kSyncPromoStartupCount, 0,
+ PrefRegistrySyncable::UNSYNCABLE_PREF);
+ registry->RegisterBooleanPref(prefs::kSyncPromoUserSkipped, false,
+ PrefRegistrySyncable::UNSYNCABLE_PREF);
+ registry->RegisterBooleanPref(prefs::kSyncPromoShowOnFirstRunAllowed, true,
+ PrefRegistrySyncable::UNSYNCABLE_PREF);
+
+ SyncPromoHandler::RegisterUserPrefs(registry);
}
// static

Powered by Google App Engine
This is Rietveld 408576698